Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<PackageReference Include="Microsoft.Data.OData" Version="5.8.4" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
<PackageReference Include="Microsoft.Playwright" Version="1.52.0" />
<PackageReference Include="Microsoft.Playwright" Version="1.55.0" />
<PackageReference Include="Microsoft.PowerFx.Interpreter" Version="$(PowerFxVersion)" />
<PackageReference Include="Microsoft.PowerFx.Json" Version="$(PowerFxVersion)" />
<PackageReference Include="Microsoft.PowerFx.Dataverse.Eval" Version="$(PowerFxVersion)" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,22 @@ public async Task SetupAsync(IUserManager userManager)
staticContext.Args = (staticContext.Args ?? Array.Empty<string>()).Concat(headlessArgs).ToArray();
}

var browser = PlaywrightObject[browserConfig.Browser];
// Use indexer for valid browser (tests assert this), translate null or ArgumentException to UserInputException
IBrowserType browser = null;
try
{
browser = PlaywrightObject[browserConfig.Browser];
}
catch (ArgumentException)
{
// Ensure we map any Playwright internal invalid browser exceptions to UserInputException
_singleTestInstanceState.GetLogger().LogError(BrowserNotSupportedErrorMessage);
throw new UserInputException(UserInputException.ErrorMapping.UserInputExceptionInvalidTestSettings.ToString());
}

if (browser == null)
{
_singleTestInstanceState.GetLogger().LogError("Browser not supported by Playwright, for more details check https://playwright.dev/dotnet/docs/browsers");
_singleTestInstanceState.GetLogger().LogError(BrowserNotSupportedErrorMessage);
throw new UserInputException(UserInputException.ErrorMapping.UserInputExceptionInvalidTestSettings.ToString());
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<PackageReference Include="Microsoft.Data.OData" Version="5.8.4" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
<PackageReference Include="Microsoft.Playwright" Version="1.52.0" />
<PackageReference Include="Microsoft.Playwright" Version="1.55.0" />
<PackageReference Include="Microsoft.PowerFx.Interpreter" Version="$(PowerFxVersion)" />
<PackageReference Include="Mono.Cecil" Version="0.11.6" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
Expand Down
2 changes: 1 addition & 1 deletion src/testengine.common.user/testengine.common.user.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Playwright" Version="1.52.0" />
<PackageReference Include="Microsoft.Playwright" Version="1.55.0" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/testengine.module.mda/testengine.module.mda.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
<PackageReference Include="Microsoft.Playwright" Version="1.52.0" />
<PackageReference Include="Microsoft.Playwright" Version="1.55.0" />
<PackageReference Include="Microsoft.PowerFx.Interpreter" Version="$(PowerFxVersion)" />
<PackageReference Include="System.ComponentModel.Composition" Version="5.0.0" />
</ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
<PackageReference Include="Microsoft.Playwright" Version="1.52.0" />
<PackageReference Include="Microsoft.Playwright" Version="1.55.0" />
<PackageReference Include="Microsoft.PowerFx.Interpreter" Version="$(PowerFxVersion)" />
<PackageReference Include="System.ComponentModel.Composition" Version="5.0.0" />
</ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
<PackageReference Include="Microsoft.Playwright" Version="1.52.0" />
<PackageReference Include="Microsoft.Playwright" Version="1.55.0" />
<PackageReference Include="Microsoft.PowerFx.Interpreter" Version="$(PowerFxVersion)" />
<PackageReference Include="System.ComponentModel.Composition" Version="5.0.0" />
<PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
<PackageReference Include="Microsoft.Playwright" Version="1.52.0" />
<PackageReference Include="Microsoft.Playwright" Version="1.55.0" />
<PackageReference Include="Microsoft.PowerFx.Interpreter" Version="$(PowerFxVersion)" />
<PackageReference Include="System.ComponentModel.Composition" Version="5.0.0" />
</ItemGroup>
Expand Down