Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.71 changelogs #27094

Merged
merged 8 commits into from
Jul 5, 2023
Merged

0.71 changelogs #27094

merged 8 commits into from
Jul 5, 2023

Conversation

stefansjfw
Copy link
Collaborator

Summary of the Pull Request

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@stefansjfw stefansjfw requested a review from crutkas June 28, 2023 20:24
@github-actions

This comment has been minimized.

Copy link
Collaborator

@Aaron-Junker Aaron-Junker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But we also could add a call for feedback for #26726

README.md Outdated Show resolved Hide resolved
@stefansjfw
Copy link
Collaborator Author

Note to myself: Fill in installer hashes

@Jay-o-Way
Copy link
Collaborator

Opinion on #25193?

README.md Outdated Show resolved Hide resolved
- Fixed a typo preventing the clean up script to run. Thanks [@Sajad-Lx](https://github.com/Sajad-Lx)!
- Fixed encoding on a test file to fix running tests in some configurations. Thanks [@VisualBasist](https://github.com/VisualBasist)!
- Made the GPO release assets come named with a version in the build CI output.
- Added Peek and Mouse Without Borders to GitHub templates. (This was a hotfix for 0.70)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really a feature of (this version of) the app?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. On the other hand, we also list repo Docs updates here as well

Copy link
Collaborator

@Jay-o-Way Jay-o-Way left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small things

@stefansjfw
Copy link
Collaborator Author

Opinion on #25193?

@crutkas?

@crutkas
Copy link
Member

crutkas commented Jun 30, 2023

Opinion on #25193?

@Jay-o-Way To best of my knowledge, outside of PT Contributors, we haven't seen any feedback on this topic so that is why i don't want to lean too hard on adjusting. We could have a changelog folder and put these there. And maybe then do a smaller recap of what has changed. This would enable us to still iterate on the change log together.

The big reason why we adopt this approach is time savings. Creating that tight recap is surprisingly time consuming and fragile if last minute changes happen

README.md Outdated Show resolved Hide resolved
@crutkas crutkas dismissed niels9001’s stale review July 5, 2023 17:46

change was done

@crutkas crutkas merged commit 9f1c71d into main Jul 5, 2023
@crutkas crutkas deleted the 0.71-readme branch July 5, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants