-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Peek] Add support for preview handlers #28690
[Peek] Add support for preview handlers #28690
Conversation
This comment has been minimized.
This comment has been minimized.
src/modules/peek/Peek.FilePreviewer/Controls/ShellPreviewHandlerControl.xaml.cs
Outdated
Show resolved
Hide resolved
src/modules/peek/Peek.FilePreviewer/Controls/ShellPreviewHandlerControl.xaml.cs
Show resolved
Hide resolved
...k/Peek.FilePreviewer/Previewers/ShellPreviewHandlerPreviewer/ShellPreviewHandlerPreviewer.cs
Show resolved
Hide resolved
...k/Peek.FilePreviewer/Previewers/ShellPreviewHandlerPreviewer/ShellPreviewHandlerPreviewer.cs
Show resolved
Hide resolved
🔥🔥🔥 O_O 🔥🔥🔥 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! This is a great contribution! Thank you so much!
LGTM, too. I'm a bit skeptical of the unsafe use too, but it makes sense here and the code doesn't look bad intentioned.
We've won gcode from our file previewers from this as well.
I love that it's used as a previewer only if Peek doesn't support that file with the other previewers already.
Tested on a computer that has office installed and this is previewing Office files as well, so I'm guessing we can "check" those as well.
Great contribution, once again! 😄
Summary of the Pull Request
This PR adds support for preview handlers that displays previews from supported applications like Microsoft Office (assuming the user has it installed).
This should also help with:
IPreviewHandler
) that's built into Windows and gets hosted by file managers like File Explorer and Everything.PR Checklist
Detailed Description of the Pull Request / Additional comments
Word
Excel
PowerPoint
Visio
Fonts