Color picker - Lab format: use roundoff optional #13603

[ruthiesun]

Summary of the Pull Request

The default CIELab format rounds the values to two decimal places, which is a degree of precision that isn't always needed. This PR adds an optional formatting character (i) to the three CIELab format parameters, which rounds the value to the nearest integer.

PR Checklist

• Closes: Color picker - Lab format: use roundoff optional #13603/[Color Picker] Allow rounding to whole numbers for formats, example CIELAB #14863. Note that in the discussion for Color picker - Lab format: use roundoff optional #13603, there are some additional suggestions that this PR doesn't address.
• Communication: Haven't gotten the green light for this approach with the core contributors yet. Happy to pivot to a different approach if needed.
• Tests: Added/updated and all pass
• Localization: All end-user-facing strings can be localized
• Dev docs: Added/updated
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

In the case where a or b get rounded to -0 (e.g. -0.0001 rounds to -0), the negative sign gets removed. However, I noticed during testing that the default format (rounding to two decimal places) retains the negative sign in these situations (see third screenshot). I can a) revert to keeping the -0 for the new rounding behavior, b) change -0 to 0 for other rounded values, or c) leave it as-is. Also open to suggestions.

I can update the docs as well, if we're happy with the approach.

Validation Steps Performed

• Settings: Can change the default CIELab format to display rounded values
• Settings: Can create a custom format with rounded CIELab values
• Color Picker: Rounded values are displayed when hovering and as a saved color

[ruthiesun]

@microsoft-github-policy-service agree