Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement best checkpointer #75

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nifarn
Copy link
Contributor

@nifarn nifarn commented Dec 3, 2021

Implementation of best checkpointer as drawn from personalization repo.

@ghost
Copy link

ghost commented Dec 3, 2021

CLA assistant check
All CLA requirements met.

@jsleep jsleep requested a review from egonzalez125 December 6, 2021 22:58
pymarlin/utils/checkpointer/checkpoint_utils.py Outdated Show resolved Hide resolved
pymarlin/utils/checkpointer/checkpoint_utils.py Outdated Show resolved Hide resolved
paths.append(super().save(checkpoint_state, index, force))
if self.args.checkpoint and ((index % self.args.period == 0) or force):
# TODO grab this from logged metrics instead
metric = float(checkpoint_state.module_interface_state[self.args.metric_name])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this part feels hacky if not pulled from metrics in terms of the design patterns used here, but either way I think adding logging here would be good (available metrics, metric selected and its value)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants