Instrument tests: Avoid leaking state between tests #5360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2023
Codecov Report
@@ Coverage Diff @@
## master #5360 +/- ##
==========================================
+ Coverage 68.14% 68.22% +0.07%
==========================================
Files 341 341
Lines 29845 29847 +2
==========================================
+ Hits 20339 20362 +23
+ Misses 9506 9485 -21 |
jenshnielsen
commented
Sep 13, 2023
jenshnielsen
force-pushed
the
jenshnielsen/cleanup_visa_inst_tests
branch
from
5a03b80 to
62bc106
Compare
jenshnielsen
force-pushed
the
jenshnielsen/cleanup_visa_inst_tests
branch
from
62bc106 to
adcd46c
Compare
astafan8
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all pyvisa-sim instruments defined by a yaml file is closed reset the instruments. This in practice will ensure that every test will reset the state of pyvisa-sim instruments on exit since the test must close instruments anyway.
closes #5356
See pyvisa/pyvisa-sim#83 for details