Import global settings from environment #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -128,32 +128,76 @@ function Initialize-StoreIngestionApiGlobalVariables | |||
| # SilentlyContinue would cause it to go into the global $Error array, Ignore prevents that as well. | |||
| if (!(Get-Variable -Name SBDefaultProxyEndpoint -Scope Global -ValueOnly -ErrorAction Ignore)) | |||
| { | |||
| $global:SBDefaultProxyEndpoint = $null | |||
| if ($env:SBDefaultProxyEndpoint) | |||
There was a problem hiding this comment.
Any reason not to uses Get-Variable like we do above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When they're unset, take the ingestion config options from environment variables if available. If not, fill in hard-coded defaults like normal.