Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added build container, devcontainer, and vscode project settings #2227

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

BrendanWalsh
Copy link
Collaborator

@BrendanWalsh BrendanWalsh commented May 16, 2024

  • Created .vscode and .devcontainer
    • Proxies azure login credentials through to host machine so you don't have to login again
    • Installs all necessary build dependencies to be reusable as a build container
  • Updated .gitignore to include build container files.
  • Updated environment.yml to pin all dependencies and update pandas to 1.5.0 (1.4.0 is no longer published as a binary and building from source slows down environment restoration significantly)
  • Added tools/docker/build/ including a Dockerfile and easy build scripts for the build/dev container setup.
  • Added website/environment.yml to pin website tool version without ballooning global environment size

@acrolinxatmsft1
Copy link

Acrolinx Scorecards

A minimum total score of 80 is required.

Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.

Article Total score
(Required: 80)
Words + phrases
(Brand, terms)
Correctness
(Spelling, grammar)
Clarity
(Readability)
website/README.md 100 100 100 100
website/environment.yml 100 100 100 100

More information about Acrolinx

@acrolinxatmsft1
Copy link

Acrolinx Scorecards

A minimum total score of 80 is required.

Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.

Article Total score
(Required: 80)
Words + phrases
(Brand, terms)
Correctness
(Spelling, grammar)
Clarity
(Readability)
website/README.md 100 100 100 100
website/environment.yml 100 100 100 100

More information about Acrolinx

@mhamilton723
Copy link
Collaborator

Very interesting is this a rehydration of Dan Cs work?

@BrendanWalsh
Copy link
Collaborator Author

Very interesting is this a rehydration of Dan Cs work?

This is from scratch but credit to Dan for first putting forth the idea

@acrolinxatmsft1
Copy link

Acrolinx Scorecards

A minimum total score of 80 is required.

Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.

Article Total score
(Required: 80)
Words + phrases
(Brand, terms)
Correctness
(Spelling, grammar)
Clarity
(Readability)
website/README.md 100 100 100 100
website/environment.yml 100 100 100 100

More information about Acrolinx

@mhamilton723
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.60%. Comparing base (46f16e0) to head (c750f7a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2227      +/-   ##
==========================================
- Coverage   80.83%   78.60%   -2.23%     
==========================================
  Files         327      327              
  Lines       16773    16773              
  Branches     1511     1511              
==========================================
- Hits        13558    13184     -374     
- Misses       3215     3589     +374     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants