chore: Optimizing the method getOptionalParams in HasOpenAITextParams #2315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
The method
getOptionalParams
inHasOpenAITextParams
was implemented in such a way that for every row in the data frame it will:logprobs
logprobs
parameterWe can do better to make code cleaner and more readable.
What changes are proposed in this pull request?
One of the reason for creating a list of all shared text parameters except
logprobs
is that we wanted to name these parameters in snake-case. We can do this while creating parameter object, hence no need to call method to generate snake-case for every iteration. This way we can put all parameters in a single list.How is this patch tested?
Since this essentially just refactoring the code, I have tested this by running the tests. Existing tests should validate that the code is working as expected
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?