This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
Removing sign in and publishing #509
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoskal
reviewed
May 10, 2018
| @@ -1575,7 +1442,6 @@ module TDev.Browser { | |||
| private mainContent = div("hubContent"); | |||
| private logo = div("hubLogo", SVG.getTopLogo()); | |||
| private bglogo = div("hubBgLogo", HTML.mkImg("svg:touchDevelop,currentColor", '', '', true)); | |||
| private meBox = div("hubMe"); | |||
There was a problem hiding this comment.
Wasn't that where the "read only" banner would go?
There was a problem hiding this comment.
I still have the banner accross the screen.
mmoskal
reviewed
May 10, 2018
rt/cloud.ts
Outdated
| @@ -343,7 +344,9 @@ module TDev.Cloud { | |||
| return !fullTD; | |||
| } | |||
|
|
|||
| export function getServiceUrl() { return config.rootUrl; } | |||
| export function getServiceUrl() { | |||
| return config.newCdnUrl || config.rootUrl; | |||
There was a problem hiding this comment.
No, no. newCdnUrl should be only used for art. I shall fix.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.