Added upper bounds for sequences #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EliasC
changed the title
|
I have updated this PR to generalise the |
mjp41
reviewed
Dec 4, 2024
include/trieste/wf.h
Outdated
Comment on lines
267
to
278
| Sequence& operator[](size_t new_len) | ||
| { | ||
| minlen = new_minlen; | ||
| if (!has_minlen) | ||
| { | ||
| minlen = new_len; | ||
| has_minlen = true; | ||
| } | ||
| else | ||
| { | ||
| maxlen = new_len; | ||
| } | ||
| return *this; |
There was a problem hiding this comment.
Should we detect
Foo++[1][2][3]as an error? Should we error for maxlen < minlen?
There was a problem hiding this comment.
Neither of the errors give a strange behavior, but I guess it would be a slightly nicer user experience to check for it. I will add it...
There was a problem hiding this comment.
I agree failing silently is in keeping with the codebase. ;)
|
Added bounds checking ( |
sylvanc
approved these changes
Dec 16, 2024
matteB10
pushed a commit
to matteB10/Trieste
that referenced
this pull request
Dec 20, 2024
* Added top-level option shape to well-formedness specifications * Replaced Option class by extended Sequence class * Bounds checking for sequences --------- Co-authored-by: Sylvan Clebsch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for giving upper bounds for sequences in the well-formedness specifications:
One motivating use case is having a top-level optional shape (which is shorthand for
++[0][1]):Before this, the closest you could get was using
++, which would mess with fuzz testing. Just as sequences, optional shapes can only be used at the top level of a shape; you still cannot write e.g.Paren <<= Foo * ~BarorParen <<= Foo * Bar++.The JSON parser had
File <<= Group++even though the initial parse pass can produce at most one group, but I did not find any more interesting usages of this pattern in any other sample or parser. Manual toying around with this seems to suggest that both checking and generation handles the new shape correctly.