Actually test the Python translator #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Apr 22, 2024
| @@ -0,0 +1,137 @@ | |||
| # serializer version: 1 | |||
There was a problem hiding this comment.
What is this file? I don't see it mentioned anywhere, but maybe you have some clever test setup that uses this?
There was a problem hiding this comment.
Yeah, syrupy is a pytest plugin that makes it easy-ish to generate snapshot/baseline tests. They have a default snapshot format called Amber (which I've never heard of before using it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for Python translators by mocking a model and snapshotting the log.
Based on feedback from @gvanrossum where he pointed out that we don't actually use the repaired prompt (I broke this in #203). Some of the fixes are already in #238.