Include non-enumerable keys in __importStar helper #60262
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
__importStar
helper to include non-enumerable own keys to ensure the following two cases are consistent:vs
The discrepancy occurs when the module
"mod"
produces exports that are non-enumerable, such as:In the above case,
C.b
is an own static method ofC
which makes it non-enumerable by default.The other way to address this would be to also wrap
mod_2
'srequire
in__importStar
so that we apply the rule consistently in both cases, but that would be a major breaking change as it has the potential to break existing users w/o warning.The companion PR for
tslib
can be found at microsoft/tslib#272.Fixes #45133