Upgrader: NuGet Upgrader should use GitHub endpoint for notifications

Fixes a bug where NuGet Upgrader no longer checks the GitHub endpoint to determine whether to show a notification that an upgrade is available. This did not affect the actual upgrade command, just whether to show a notification.
microsoft · Jun 20, 2019 · 9a67103 · 9a67103
1 parent 139600c
commit 9a67103
Showing 1 changed file with 16 additions and 14 deletions.
diff --git a/GVFS/GVFS.Service/ProductUpgradeTimer.cs b/GVFS/GVFS.Service/ProductUpgradeTimer.cs
@@ -139,20 +139,22 @@ private void TimerCallback(object unusedState)
                                 return;
                             }
                         }
-
-                        errorMessage = string.Format(
-                            "{0}.{1}: Configured Product Upgrader does not support anonymous version queries.",
-                            nameof(ProductUpgradeTimer),
-                            nameof(this.TimerCallback),
-                            errorMessage);
-
-                        activity.RelatedWarning(
-                            metadata: new EventMetadata(),
-                            message: errorMessage,
-                            keywords: Keywords.Telemetry);
-
-                        info.RecordHighestAvailableVersion(highestAvailableVersion: null);
-                        return;
+                        else
+                        {
+                            errorMessage = string.Format(
+                                "{0}.{1}: Configured Product Upgrader does not support anonymous version queries.",
+                                nameof(ProductUpgradeTimer),
+                                nameof(this.TimerCallback),
+                                errorMessage);
+
+                            activity.RelatedWarning(
+                                metadata: new EventMetadata(),
+                                message: errorMessage,
+                                keywords: Keywords.Telemetry);
+
+                            info.RecordHighestAvailableVersion(highestAvailableVersion: null);
+                            return;
+                        }
                     }
 
                     InstallerPreRunChecker prerunChecker = new InstallerPreRunChecker(this.tracer, string.Empty);