Skip to content

Conversation

@AvrumFeldman
Copy link

I updated the script to by default use the latest releases of the packages instead of relying on hardcoded versions. I still left the option for hardcoded versions in case someone wants to use specific versions.

@AvrumFeldman
Copy link
Author

I see now I need to fix some code. Please hold off on approving the pull request.

@AvrumFeldman
Copy link
Author

Ok, I just tested my last commit and it's working as expected.

I did notice that CNI is being downloaded twice, once in New-ContainerTransparentNetwork and another time in Install-Containerd. In the New-ContainerTransparentNetwork the version was hardcoded without the ability to define the version (even though there is a parameter for static version. In my pull request I just hardcoded to always use the latest version. The question is whether

  • We leave it like this.
  • Or maybe either eliminate the redundant downloading and installation (will require moving install-containerd to be executed before New-ContainerTransparentNetwork in Install-ContainerDHost).
  • Or I can add the dynamic option in New-ContainerTransparentNetwork just like I did in Install-Containerd.

@microsoft-github-policy-service
Copy link
Contributor

This issue has been open for 30 days with no updates.
no assignees, please provide an update or close this issue.

4 similar comments
@microsoft-github-policy-service
Copy link
Contributor

This issue has been open for 30 days with no updates.
no assignees, please provide an update or close this issue.

@microsoft-github-policy-service
Copy link
Contributor

This issue has been open for 30 days with no updates.
no assignees, please provide an update or close this issue.

@microsoft-github-policy-service
Copy link
Contributor

This issue has been open for 30 days with no updates.
no assignees, please provide an update or close this issue.

@microsoft-github-policy-service
Copy link
Contributor

This issue has been open for 30 days with no updates.
no assignees, please provide an update or close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant