simbatt: Clear BATTERY_CAPACITY_RELATIVE field for per-battery charge display #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forderud
force-pushed
the
simbatt-relative-rm
branch
from
e285432 to
4149179
Compare
forderud
force-pushed
the
simbatt-relative-rm
branch
from
4149179 to
38797e5
Compare
|
Gentle reminder. |
|
@JakobL-MSFT Would it be possible to get some kind of explanation for why this PR was closed instead of being considered for merging? |
|
I closed this PR unintentionally. I apologize. I am reopening the PR. |
forderud
force-pushed
the
simbatt-relative-rm
branch
from
38797e5 to
fe85bdb
Compare
Clear BATTERY_INFORMATION::BATTERY_CAPACITY_RELATIVE field to enable per-battery charge display in Windows Settings.
forderud
force-pushed
the
simbatt-relative-rm
branch
from
fe85bdb to
97b9377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear
BATTERY_INFORMATION::BATTERY_CAPACITY_RELATIVEfield to enable per-battery charge display in Windows Settings when simulating multi-battery setups.Motivating example
Example of simulated multi-battery setup prior to this PR:
As you can see, the individual batteries report 0% despite being fully charged. The aggregated 100% charge is however correct.
Corresponding example after clearing the
BATTERY_CAPACITY_RELATIVEfield:As you can see, the individual batteries now correctly report 100%.
Testing instructions
Steps:
simbatt\func\simbatt.slnsolution.