Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues in vhid samples #1084

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Fix build issues in vhid samples #1084

merged 5 commits into from
Jan 23, 2024

Conversation

zlockard
Copy link
Collaborator

No description provided.

@zlockard zlockard requested a review from a team as a code owner January 22, 2024 23:31
@JakobL-MSFT
Copy link
Contributor

First. I spotted that "This branch is 1 commit ahead of, 2 commits behind main.".

I did following:
git checkout vhid_updated
git merge main
edit of exclusion.csv to remove hid samples from exclusion list.
git push

With this pushed I see:

  • Following still fails for in market EWDK:
    .\build-AllSamples.ps1 -samples "^hid"

  • Here is the log output:
    Build errors in Sample hid.hidusbfx2; Configuration: Debug; Platform: x64 {
    C:\Users\jakobl\source\repos\Windows-driver-samples\Wds4\hid\hidusbfx2\sys\hidusbfx2.inx(77-77): error 2087: (NTamd64.6.1) Service binary 'C:\WINDOWS\System32\drivers\mshidkmdf.sys' should reference a CopyFiles destination file. [C:\Users\jakobl\source\repos\Windows-driver-samples\Wds4\hid\hidusbfx2\sys\hidusbfx2.vcxproj]
    } hid.hidusbfx2 Debug|x64
    Build errors in Sample hid.hidusbfx2; Configuration: Release; Platform: x64 {
    C:\Users\jakobl\source\repos\Windows-driver-samples\Wds4\hid\hidusbfx2\sys\hidusbfx2.inx(77-77): error 2087: (NTamd64.6.1) Service binary 'C:\WINDOWS\System32\drivers\mshidkmdf.sys' should reference a CopyFiles destination file. [C:\Users\jakobl\source\repos\Windows-driver-samples\Wds4\hid\hidusbfx2\sys\hidusbfx2.vcxproj]
    } hid.hidusbfx2 Release|x64

  • Following passes for GE EWDK:
    .\build-AllSamples.ps1 -samples "^hid"

Copy link
Contributor

@JakobL-MSFT JakobL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zlockard zlockard merged commit 19e6435 into main Jan 23, 2024
7 checks passed
@JakobL-MSFT JakobL-MSFT deleted the vhid_updates branch February 15, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants