Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update configuration.dsc.yml for 26100 #1168

Closed
wants to merge 4 commits into from
Closed

update configuration.dsc.yml for 26100 #1168

wants to merge 4 commits into from

Conversation

jacob-ronstadt
Copy link
Contributor

No description provided.

@jacob-ronstadt jacob-ronstadt requested a review from a team as a code owner May 16, 2024 22:54
NeoAdonis
NeoAdonis suggested changes May 20, 2024
View reviewed changes
Copy link
Contributor

@NeoAdonis NeoAdonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the target branch to main, please? The change can then be merged into develop as well.

configuration.dsc.yaml Show resolved Hide resolved
@jacob-ronstadt jacob-ronstadt changed the base branch from develop to main May 20, 2024 16:18
@jacob-ronstadt jacob-ronstadt requested a review from a team as a code owner May 20, 2024 16:18
@NeoAdonis
Copy link
Contributor

After changing target branch, it seems that there's an extra commit that shouldn't be merged. Could you rebase the branch to use main so that the commit doesn't appear, please?

@NeoAdonis NeoAdonis removed the request for review from a team May 20, 2024 22:54
@jacob-ronstadt
Copy link
Contributor Author

After changing target branch, it seems that there's an extra commit that shouldn't be merged. Could you rebase the branch to use main so that the commit doesn't appear, please?

Which commit are you referring to? b03f?

@jacob-ronstadt
Copy link
Contributor Author

Closing to change branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeoAdonis NeoAdonis NeoAdonis requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacob-ronstadt @NeoAdonis @thpthp1