Support for Enum types with DataTriggerBehavior #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented DataTrigger with Enum sample
|
|
pdecostervgls
changed the title
pdecostervgls
changed the title
Changed Column distribution for DataTriggerBehavior|Enum
skendrot
requested changes
May 10, 2019
|
@skendrot Have you had time to review this again yet? |
skendrot
reviewed
Jun 12, 2020
src/BehaviorsSDKManaged/Microsoft.Xaml.Interactions/Core/TypeConverterHelper.cs
Show resolved
Hide resolved
|
Still not accepted? C'mon guys, its been over a year now for such a small change... |
|
@skendrot Half-yearly reminder that this PR is still open. |
|
Another year later, this is still open. |
|
@michael-hawker, could you take a look at this? or redirect to someone who actually can merge this? @skendrot seems to not be active anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented support for Enum types with DataTriggerBehavior.
Fixes #84.
Credits go to @P4bl3r (#136) for the implementation, I'm just doing the PR because its an old issue.