Fix up error reporting for VideoTexture

microsoft · Aug 6, 2020 · 4024860 · 4024860
1 parent 398f16a
commit 4024860
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 16 deletions.
diff --git a/PCSamples/Graphics/VideoTexturePC12/MediaEnginePlayer.cpp b/PCSamples/Graphics/VideoTexturePC12/MediaEnginePlayer.cpp
@@ -315,15 +315,22 @@ void MediaEnginePlayer::OnMediaEngineEvent(uint32_t meEvent)
             break;
 
         case MF_MEDIA_ENGINE_EVENT_ERROR:
-            #ifdef _DEBUG
+        #ifdef _DEBUG
             if (m_mediaEngine)
             {
                 ComPtr<IMFMediaError> error;
-                m_mediaEngine->GetError(&error);
-                USHORT errorCode = error->GetErrorCode();
-                char buff[128] = {};
-                sprintf_s(buff, "ERROR: Media Foundation Event Error %u", errorCode);
-                OutputDebugStringA(buff);
+                if (SUCCEEDED(m_mediaEngine->GetError(&error)))
+                {
+                    USHORT errorCode = error->GetErrorCode();
+                    HRESULT hr = error->GetExtendedErrorCode();
+                    char buff[128] = {};
+                    sprintf_s(buff, "ERROR: Media Foundation Event Error %u (%08X)\n", errorCode, static_cast<unsigned int>(hr));
+                    OutputDebugStringA(buff);
+                }
+                else
+                {
+                    OutputDebugStringA("ERROR: Media Foundation Event Error *FAILED GetError*\n");
+                }
             }
             #endif
             break;

diff --git a/UWPSamples/Graphics/VideoTextureUWP/MediaEnginePlayer.cpp b/UWPSamples/Graphics/VideoTextureUWP/MediaEnginePlayer.cpp
@@ -283,11 +283,18 @@ void MediaEnginePlayer::OnMediaEngineEvent(uint32_t meEvent)
             if (m_mediaEngine)
             {
                 ComPtr<IMFMediaError> error;
-                m_mediaEngine->GetError(&error);
-                USHORT errorCode = error->GetErrorCode();
-                char buff[128] = {};
-                sprintf_s(buff, "ERROR: Media Foundation Event Error %u", errorCode);
-                OutputDebugStringA(buff);
+                if (SUCCEEDED(m_mediaEngine->GetError(&error)))
+                {
+                    USHORT errorCode = error->GetErrorCode();
+                    HRESULT hr = error->GetExtendedErrorCode();
+                    char buff[128] = {};
+                    sprintf_s(buff, "ERROR: Media Foundation Event Error %u (%08X)\n", errorCode, static_cast<unsigned int>(hr));
+                    OutputDebugStringA(buff);
+                }
+                else
+                {
+                    OutputDebugStringA("ERROR: Media Foundation Event Error *FAILED GetError*\n");
+                }
             }
             #endif
             break;

diff --git a/UWPSamples/Graphics/VideoTextureUWP12/MediaEnginePlayer.cpp b/UWPSamples/Graphics/VideoTextureUWP12/MediaEnginePlayer.cpp
@@ -319,11 +319,18 @@ void MediaEnginePlayer::OnMediaEngineEvent(uint32_t meEvent)
             if (m_mediaEngine)
             {
                 ComPtr<IMFMediaError> error;
-                m_mediaEngine->GetError(&error);
-                USHORT errorCode = error->GetErrorCode();
-                char buff[128] = {};
-                sprintf_s(buff, "ERROR: Media Foundation Event Error %u", errorCode);
-                OutputDebugStringA(buff);
+                if (SUCCEEDED(m_mediaEngine->GetError(&error)))
+                {
+                    USHORT errorCode = error->GetErrorCode();
+                    HRESULT hr = error->GetExtendedErrorCode();
+                    char buff[128] = {};
+                    sprintf_s(buff, "ERROR: Media Foundation Event Error %u (%08X)\n", errorCode, static_cast<unsigned int>(hr));
+                    OutputDebugStringA(buff);
+                }
+                else
+                {
+                    OutputDebugStringA("ERROR: Media Foundation Event Error *FAILED GetError*\n");
+                }
             }
             #endif
             break;