Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wcag-2-2): add "consistent help" test #7060

Merged
merged 12 commits into from
Oct 31, 2023

Conversation

codeofdusk
Copy link
Contributor

Details

This PR adds "consistent help" from WCAG 2.2 to the "repetitive content" assessment.

Motivation

Part of the WCAG 2.2 feature (accessible to internal engineers on Azure DevOps).

Pull request checklist

  • [n/a] Addresses an existing issue: #0000
  • Ran yarn fastpass
  • [n/a] Added/updated relevant unit test(s) (and ran yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@codeofdusk codeofdusk requested a review from a team as a code owner October 26, 2023 23:30
Copy link
Contributor

@madalynrose madalynrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update links to be in line with other requirements

src/content/test/repetitive-content/consistent-help.tsx Outdated Show resolved Hide resolved
src/content/test/repetitive-content/consistent-help.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@madalynrose madalynrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made suggestions to update em tags to use Markup.Emphasis instead.

Copy link
Contributor

@madalynrose madalynrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeofdusk codeofdusk merged commit ac4cd8c into microsoft:main Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants