Update ARM template & documentation #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracez72
requested review from
guptaharsh25,
nnmkhang,
kodyang,
beervoley and
daniellemott
guptaharsh25
approved these changes
Apr 22, 2020
daniellemott
approved these changes
Apr 22, 2020
beervoley
added a commit
that referenced
this pull request
Apr 22, 2020
* updated models to move owner from template to template instance * Update in memory to have owner per template instance * Update backend logic to handle owners on a per template instance level * update owner to author * update client sdk * fix tests * fix test * Fix tesT * Users/hagupt/version modal toggle (#214) * version toggle work * version toggle works * quick fix * Change font (#223) * Change font * Adjust styling based on Naomi's designs * Finish up fonts * Remove unused font * Revert changes in designer * Changes fonts in Error page * Add get templates by template state (#228) * remove ispublished, replace with state * remove unused Co-authored-by: Grace Zhang <[email protected]> * grace * Add tag support to All Cards page (#219) * Add All Cards Page * Profile Picture Bug + Long Title Bug (#221) * fix bug by requiring graph id in auth hoc * ellipses to long titles * Re-add deploy to azure button (#230) * readd deploy to azure pr with updated build * add package dependency * fix error * add check Co-authored-by: Grace Zhang <[email protected]> * Add favorite tags endpoint (#220) * add favorite tags endpoint * edit unfavourite endpoint * change to delete favorite * fix client SDK Co-authored-by: Grace Zhang <[email protected]> * Publish Modal UI update (#225) * publish modal refining design * refactor publish modal file * remove unnecessary font family declarations * Update documentation (#227) * update readme with latest instructions for deployment * remove app service from template * remove custom db * reformat * add status as table * add contributing file * reformat * Update CONTRIBUTING.md * Update CONTRIBUTING.md * add architecture diagram' * add png * Update CONTRIBUTING.md * remove line numbers' * update import * add telemetry privacy statement * update wording * update wording * fix formatting Co-authored-by: Grace Zhang <[email protected]> * Add client secret to AZ Key Vault (#229) * Fetch secret from Azure * AZ Key Vault * Try again * run tests * Secrets * secrets * Add var section * Try * * try list * Get multiple * Update pipelines * Add trigger none * clean up pipelines * Run again * Remove extra vars * reset stage-pr * Remove extra frontend env vars * Fix typo (#241) * fix typo * test * Fix typo * Add CosmosDB to deploy to azure button (#232) * add database * add plan * fix syntax * remove server far * remove custom db Co-authored-by: Grace Zhang <[email protected]> * Add documentation for flow & private connector (#233) * add flow swagger * add connector instructions * Add flow screenshot * add flow instructions * Update README.md * Update README.md Co-authored-by: Grace Zhang <[email protected]> * update config api base path (#240) * Share Modal UI Update (#234) * publish modal refining design * redo share modal UI * refactor publish modal file * remove import * remove font family line * Unpublish Modal UI Update (#235) * publish modal refining design * redo share modal UI * refactor publish modal file * remove import * unpublish modal UI revision * remove font family line * didn't save strings file whoops * Connect Publish modal to Share modal (#236) * publish modal refining design * redo share modal UI * refactor publish modal file * remove import * unpublish modal UI revision * onPublishClick, we publish and open share modal * remove font family line * didn't save strings file whoops * merge from dev * Rename pipelines (#242) * Users/nnmkhang/sort filter (#208) * basic functionality for sort working * adding tag+name search for in memorydb * adding or functionality for mongodb * removing console.logs' * cleaning up small nits * removing unneeded imports * removing code, this will be added after * nit: adding space * add case insensitivity for tag search * Adding filter to redux store, Moving both searchQuery dispatches from sort/filter to the parent function (cherry picked from commit 42a3b87) * add newline * removing console log * applying changes on top of graces' PR * switching logic for in memory db * test * Fixed tests, changed name from publihsed -> state in filter * Share Successful Modal (#237) * publish modal refining design * redo share modal UI * refactor publish modal file * remove import * unpublish modal UI revision * onPublishClick, we publish and open share modal * share success modal implemented * remove font family line * didn't save strings file whoops * merge from dev * mapStateToProps was unused * HTML landmark elements added * Tooltips on All Cards page (#239) * added tooltips and removed console warnings * remove setState declarations * Move CODEOWNERS (#246) * Codeowners * Change location * [Accessibility]: Landmark HTML Elements (#243) * added landmark elements across the app * make tag section on preview page a form * changing template to card in strings * Opt-in telemetry + fix frontend telemetry bug (#238) * Telem opt-in * Add changes to azuredeploy.json * Update docs * Spacing * add link * spacing * Wording * "Tall" adaptive card bugs (#231) * Fix UI bugs * UI bugs * Unused imports * Reverse CSS changes * Save and Publish Modal (#244) * publish modal refining design * redo share modal UI * refactor publish modal file * remove import * unpublish modal UI revision * onPublishClick, we publish and open share modal * share success modal implemented * working on save and publish modal * save and publish implemented and embedded into workflow * remove font family line * didn't save strings file whoops * merge from dev * mapStateToProps was unused * html landmark added * remove pink text on Publish button * dynamically determine new version number * removed stray letter t * formatting fix * Upon Save&Publish, Share modal opens (#245) * publish modal refining design * redo share modal UI * refactor publish modal file * remove import * unpublish modal UI revision * onPublishClick, we publish and open share modal * share success modal implemented * working on save and publish modal * save and publish implemented and embedded into workflow * on click save and publish, modal closes and share modal opens * remove font family line * didn't save strings file whoops * merge from dev * mapStateToProps was unused * html landmark added * remove pink text on Publish button * dynamically determine new version number * removed stray letter t * Add collaborators to template info page and fix version update timestamp (#248) * fix timestamp update * add people column in template info page * add number * remove unused * change owner avatar to persona Co-authored-by: Grace Zhang <[email protected]> * No cards placeholders (#247) * add placeholders * Fix flow image * Trim whitespace (#251) * Localization (#249) * Start localization * Localization... * X( * Add more to localization * Forgot a couple * unused import * Update aria labels * Add PoliCheck (#256) * Test policheck * Test policheck again * try again * again * syntax * change jobs * indentation * Add stages * Add conditional * Add policheck * test out on pr * syntax * Clean up * Remove extra policheck step * Test again * Test poliCheck * try again * Add swear word * test again * No deploy * Revert * Again * ???? * ??????????????????????? * Test dev and stage * reset stage and dev * Favorite Tags + Tags on Dashboard (#250) * Add Favorite Tags * make large cards scrollable on shared view page (#255) * Update README.md * Removing Tags, Drafts & Publish from Sidebar (#254) * sidebar fixes aand removing console warnings * make All Cards icon white * make large cards scrollable on shared view page * merge conflicts * unused imports * fix import error * Revert "Add PoliCheck (#256)" (#257) This reverts commit ae2e95a. * Add two additional code owners for approval of PRs * Change default AC (#258) * update arm template to use dockerhub image (#253) Co-authored-by: Grace Zhang <[email protected]> * Grey out unused buttons & fix collaborator bug (#259) * fix timestamp update * add people column in template info page * add number * remove unused * change owner avatar to persona * fix collaborator bug & grey version modal buttons * remove duplicate * check collaborators size for text Co-authored-by: Grace Zhang <[email protected]> * Fix loading issue (#263) * Fix favorite tag overflow and add h1&h2 headers (#264) * fix overflow tags * add h1, h2 tags * change favorite tag to one line Co-authored-by: Grace Zhang <[email protected]> * Fix scroll on preview (#265) * Fix scroll on preview * Fix tags overflow * Fix styling in Recent Releases Table + Scroll Problem (#260) * Fix styling * Remove scroller imports * Flickering Bug (#266) * Loading bug * Final fixes * Fix bug * Switch to using sets * Unused import * temporarily remove packages (#268) Co-authored-by: Grace Zhang <[email protected]> * Move manage button to the top toolbar (#270) * Move manage button to the top toolbar * Add sort and filter to AllCards + Change url based on query in AllCards (#262) * Add Search and Filter to the portal Co-authored-by: Vsevolod Iliushin <[email protected]> Co-authored-by: Khang Nguyen <[email protected]> * Change default adaptive card on refresh (#272) * temporarily remove packages * Set default card in Designer * Pull from dev Co-authored-by: Grace Zhang <[email protected]> * Update ARM template & documentation (#269) * fix cosmosdb bug & default val for app insights * update name * fix cosmos * edit name * add common issues * update docs Co-authored-by: Grace Zhang <[email protected]> * Make authid unique (#276) * Users/vsevolod/fix db authid (#277) * Make authid unique * fix tests * Set overflow-behaviour for Designer Page (#273) * Set overflow-behaviour for Designer Page * tags and warns (#275) * tag issues and console warns Co-authored-by: Kody Yang <[email protected]> Co-authored-by: Harsh Gupta <[email protected]> Co-authored-by: Danielle Mott <[email protected]> Co-authored-by: Grace Zhang <[email protected]> Co-authored-by: Grace Zhang <[email protected]> Co-authored-by: Khang Nguyen <[email protected]> Co-authored-by: Jessica Huh <[email protected]> Co-authored-by: markAtMicrosoft <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: TASK-34662
This PR addresses the following concerns raised in ISSUE-261:
Testing this PR:
The deploy to azure button can be used to deploy the resources using the form, but the actual project will not build properly because the npm packages have been removed so that they can be switched to the official adaptivecards npm account: PR-268