Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose functionality as a library #48

Merged
merged 6 commits into from
Oct 7, 2024
Merged

Expose functionality as a library #48

merged 6 commits into from
Oct 7, 2024

Conversation

dannyvv
Copy link
Member

@dannyvv dannyvv commented Oct 4, 2024 •
edited
Loading

  • This change exposes the functionality as a library.

    • It also allows users to pass azureauth location when used as a library when the environment has a custom version of azureauth present already.

  • Fixes a typo writeWorspaceRegistries => writeWorkspaceRegistries

  • Improves error handling. In some cases AzureAuth prints warnings on stderr yet still succeeds.

@dannyvv dannyvv merged commit 1731be2 into microsoft:main Oct 7, 2024
4 checks passed
@dannyvv dannyvv mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcreamer898 jcreamer898 jcreamer898 approved these changes

@ecraig12345 ecraig12345 Awaiting requested review from ecraig12345

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannyvv @jcreamer898