Merge pull request #1009 from microsoft/develop

Merge develop to master for release 5.0.0

.github/CODEOWNERS

@@ -0,0 +1 @@
+*       @microsoft/appcenter-fte

AppCenterReactNativeShared/Products/AppCenterReactNativeShared.podspec

@@ -1,14 +1,14 @@
 Pod::Spec.new do |s|
   s.name              = 'AppCenterReactNativeShared'
-  s.version           = '4.4.5'
+  s.version           = '5.0.0'
   s.summary           = 'React Native plugin for Visual Studio App Center'
   s.license           = { :type => 'MIT',  :file => 'AppCenterReactNativeShared/LICENSE' }
   s.homepage          = 'https://github.com/microsoft/appcenter-sdk-react-native'
   s.documentation_url = "https://docs.microsoft.com/en-us/appcenter/"
   s.author            = { 'Microsoft' => '[email protected]' }
   s.source            = { :http => "https://github.com/microsoft/appcenter-sdk-react-native/releases/download/#{s.version}/AppCenter-SDK-ReactNative-iOS-Pod-#{s.version}.zip" }
-  s.platform          = :ios, '9.0'
+  s.platform          = :ios, '11.0'
   s.requires_arc      = true
   s.vendored_frameworks = 'AppCenterReactNativeShared/AppCenterReactNativeShared.xcframework'
-  s.dependency 'AppCenter/Core', '4.4.3'
+  s.dependency 'AppCenter/Core', '5.0.3'
 end

AppCenterReactNativeShared/Products/local.podspec

@@ -3,16 +3,16 @@
 
 Pod::Spec.new do |s|
   s.name              = 'AppCenterReactNativeShared'
-  s.version           = '4.4.5'
+  s.version           = '5.0.0'
   s.summary           = 'React Native plugin for Visual Studio App Center'
   s.license           = { :type => 'MIT',  :file => 'AppCenterReactNativeShared/LICENSE' }
   s.homepage          = 'https://github.com/microsoft/appcenter-sdk-react-native'
   s.documentation_url = "https://docs.microsoft.com/en-us/appcenter/"
   s.author            = { 'Microsoft' => '[email protected]' }
   system("SRCROOT=#{__dir__}/../ios #{__dir__}/../prepare-local-podspec.sh")
   s.source            = { :http => "file://#{__dir__}/AppCenter-SDK-ReactNative-iOS-Pod-#{s.version}.zip"}
-  s.platform          = :ios, '9.0'
+  s.platform          = :ios, '11.0'
   s.requires_arc      = true
   s.vendored_frameworks = 'AppCenterReactNativeShared/AppCenterReactNativeShared.xcframework'
-  s.dependency 'AppCenter/Core', '4.4.3'
+  s.dependency 'AppCenter/Core', '5.0.3'
 end

AppCenterReactNativeShared/android/build.gradle

@@ -48,8 +48,8 @@ allprojects {
         defaultConfig {
             minSdkVersion 21
             targetSdkVersion 29
-            versionCode 64
-            versionName '4.4.5'
+            versionCode 65
+            versionName '5.0.0'
             group groupId
             version versionName
             buildConfigField 'String', "SDK_NAME", "\"appcenter.react-native\""
@@ -127,7 +127,7 @@ allprojects {
 }
 
 dependencies {
-    api 'com.microsoft.appcenter:appcenter:4.4.5'
+    api 'com.microsoft.appcenter:appcenter:5.0.2'
 }
 
 artifacts {

AppCenterReactNativeShared/ios/AppCenterReactNativeShared.xcodeproj/project.pbxproj

@@ -324,7 +324,7 @@
 			buildSettings = {
 				FRAMEWORK_SEARCH_PATHS = "$(inherited)";
 				HEADER_SEARCH_PATHS = "$(inherited)";
-				IPHONEOS_DEPLOYMENT_TARGET = 9.0;
+				IPHONEOS_DEPLOYMENT_TARGET = 11.0;
 				ONLY_ACTIVE_ARCH = YES;
 				OTHER_LDFLAGS = "$(inherited)";
 				PRODUCT_NAME = AppCenterReactNativeShared;
@@ -338,7 +338,7 @@
 			buildSettings = {
 				FRAMEWORK_SEARCH_PATHS = "$(inherited)";
 				HEADER_SEARCH_PATHS = "$(inherited)";
-				IPHONEOS_DEPLOYMENT_TARGET = 9.0;
+				IPHONEOS_DEPLOYMENT_TARGET = 11.0;
 				ONLY_ACTIVE_ARCH = NO;
 				OTHER_LDFLAGS = "$(inherited)";
 				PRODUCT_NAME = AppCenterReactNativeShared;

AppCenterReactNativeShared/ios/AppCenterReactNativeShared/AppCenterReactNativeShared.m

@@ -39,7 +39,7 @@ + (NSString *)getAppSecret {
 
 + (void)configureAppCenter {
   if (!wrapperSdk) {
-    MSACWrapperSdk *wrapperSdk = [[MSACWrapperSdk alloc] initWithWrapperSdkVersion:@"4.4.5"
+    MSACWrapperSdk *wrapperSdk = [[MSACWrapperSdk alloc] initWithWrapperSdkVersion:@"5.0.0"
                                                                 wrapperSdkName:@"appcenter.react-native"
                                                          wrapperRuntimeVersion:nil
                                                         liveUpdateReleaseLabel:nil

AppCenterReactNativeShared/ios/Podfile

@@ -3,6 +3,6 @@ target 'AppCenterReactNativeShared' do
   use_frameworks!
 
   # Pods for AppCenterReactNativeShared
-  pod 'AppCenter', '4.4.3'
+  pod 'AppCenter', '5.0.3'
 
 end

AppCenterReactNativeShared/ios/Podfile.lock

@@ -1,23 +1,23 @@
 PODS:
-  - AppCenter (4.4.3):
-    - AppCenter/Analytics (= 4.4.3)
-    - AppCenter/Crashes (= 4.4.3)
-  - AppCenter/Analytics (4.4.3):
+  - AppCenter (5.0.3):
+    - AppCenter/Analytics (= 5.0.3)
+    - AppCenter/Crashes (= 5.0.3)
+  - AppCenter/Analytics (5.0.3):
     - AppCenter/Core
-  - AppCenter/Core (4.4.3)
-  - AppCenter/Crashes (4.4.3):
+  - AppCenter/Core (5.0.3)
+  - AppCenter/Crashes (5.0.3):
     - AppCenter/Core
 
 DEPENDENCIES:
-  - AppCenter (= 4.4.3)
+  - AppCenter (= 5.0.3)
 
 SPEC REPOS:
   trunk:
     - AppCenter
 
 SPEC CHECKSUMS:
-  AppCenter: 3fd04aa1b166e16fdb03ec81dabe488aece83fbd
+  AppCenter: a4070ec3d4418b5539067a51f57155012e486ebd
 
-PODFILE CHECKSUM: 956bd90bd24fac7c9ff837aaacae97c697c83881
+PODFILE CHECKSUM: 98b2521b82f9ee3dca6f88b635ef371216c02b85
 
-COCOAPODS: 1.11.0
+COCOAPODS: 1.12.1

CHANGELOG.md

@@ -1,7 +1,23 @@
 # App Center SDK for React Native Change Log
 
-## Version 4.4.6 (Under development)
+## Version 5.0.0
 
+#### Android
+
+* **[Fix]** Fix blocking crashes channel if empty or incomplete error object is passed to `Crashes.trackError`.
+* **[Fix]** Fix SDK crash if the `ConnectivityManager.getNetworkInfo` method call throws an exception.
+* **[Fix]** Fix Concurrent Modification Exception in DefaultChannel on setNetworkRequestsAllowed.
+* **[Fix]** Fix ignoring maximum storage size limit in case logs contain large payloads.
+
+#### iOS
+
+* **[Feature] Add Xcode 14 support. Xcode 11 and Xcode 12 are out of support now. Bump minumum supported iOS version to iOS 11.
+* **[Fix]** Fix NSLog congestion on Apple's Framework Thread.
+* **[Fix]** Fix Unsafe Object Deserialization.
+* **[Fix]** Fix "Collection was mutated while being enumerated" exception in MSACChannelGroupDefault.
+* **[Fix]** Fix crash channel:didPrepareLog in MSACChannelGroupDefault
+* **[Improvement]** Always specify `isDirectory` parameter for `[NSURL URLByAppendingPathComponent:]` for better performace.
+* **[Improvement]** Update PLCrashReporter to 1.11.0.
  ___
 
 ## Version 4.4.5

DemoApp/ios/DemoApp.xcodeproj/project.pbxproj

@@ -1348,7 +1348,7 @@
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CODE_SIGN_ENTITLEMENTS = DemoApp/DemoApp.entitlements;
-				CODE_SIGN_IDENTITY = "iPhone Distribution: Microsoft Corporation";
+				CODE_SIGN_IDENTITY = "iPhone Developer";
 				CODE_SIGN_STYLE = Manual;
 				CURRENT_PROJECT_VERSION = 1;
 				DEAD_CODE_STRIPPING = NO;
@@ -1371,7 +1371,7 @@
 				);
 				PRODUCT_BUNDLE_IDENTIFIER = com.microsoft.appcenter.reactnative.ios.demo;
 				PRODUCT_NAME = DemoApp;
-				PROVISIONING_PROFILE_SPECIFIER = "Appcenter Reactnative IOS demo Distribution";
+				PROVISIONING_PROFILE_SPECIFIER = "Appcenter Reactnative IOS demo Development";
 				VERSIONING_SYSTEM = "apple-generic";
 			};
 			name = Debug;
@@ -1382,7 +1382,7 @@
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CODE_SIGN_ENTITLEMENTS = DemoApp/DemoApp.entitlements;
-				CODE_SIGN_IDENTITY = "iPhone Distribution: Microsoft Corporation";
+				CODE_SIGN_IDENTITY = "iPhone Developer";
 				CODE_SIGN_STYLE = Manual;
 				CURRENT_PROJECT_VERSION = 1;
 				DEVELOPMENT_TEAM = 9KBH5RKYEW;
@@ -1404,7 +1404,7 @@
 				);
 				PRODUCT_BUNDLE_IDENTIFIER = com.microsoft.appcenter.reactnative.ios.demo;
 				PRODUCT_NAME = DemoApp;
-				PROVISIONING_PROFILE_SPECIFIER = "Appcenter Reactnative IOS demo Distribution";
+				PROVISIONING_PROFILE_SPECIFIER = "Appcenter Reactnative IOS demo Development";
 				VERSIONING_SYSTEM = "apple-generic";
 			};
 			name = Release;

DemoApp/ios/DemoApp/DemoApp.entitlements

@@ -2,8 +2,6 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
-	<key>aps-environment</key>
-	<string>development</string>
 	<key>keychain-access-groups</key>
 	<array>
 		<string>$(AppIdentifierPrefix)com.microsoft.adalcache</string>

TestApp/ios/Podfile.lock

@@ -1,22 +1,22 @@
 PODS:
-  - appcenter-analytics (4.4.5):
-    - AppCenter/Analytics (~> 4.0)
-    - AppCenterReactNativeShared (~> 4.0)
+  - appcenter-analytics (5.0.0):
+    - AppCenter/Analytics (~> 5.0)
+    - AppCenterReactNativeShared (~> 5.0)
     - React-Core
-  - appcenter-core (4.4.5):
-    - AppCenterReactNativeShared (~> 4.0)
+  - appcenter-core (5.0.0):
+    - AppCenterReactNativeShared (~> 5.0)
     - React-Core
-  - appcenter-crashes (4.4.5):
-    - AppCenter/Crashes (~> 4.0)
-    - AppCenterReactNativeShared (~> 4.0)
+  - appcenter-crashes (5.0.0):
+    - AppCenter/Crashes (~> 5.0)
+    - AppCenterReactNativeShared (~> 5.0)
     - React-Core
-  - AppCenter/Analytics (4.4.3):
+  - AppCenter/Analytics (5.0.3):
     - AppCenter/Core
-  - AppCenter/Core (4.4.3)
-  - AppCenter/Crashes (4.4.3):
+  - AppCenter/Core (5.0.3)
+  - AppCenter/Crashes (5.0.3):
     - AppCenter/Core
-  - AppCenterReactNativeShared (4.4.5):
-    - AppCenter/Core (= 4.4.3)
+  - AppCenterReactNativeShared (5.0.0):
+    - AppCenter/Core (= 5.0.3)
   - boost-for-react-native (1.63.0)
   - DoubleConversion (1.1.6)
   - FBLazyVector (0.62.3)
@@ -311,10 +311,9 @@ DEPENDENCIES:
   - Yoga (from `../node_modules/react-native/ReactCommon/yoga`)
 
 SPEC REPOS:
-  https://github.com/CocoaPods/Specs.git:
-    - boost-for-react-native
-  https://msmobilecenter.visualstudio.com/SDK/_git/AppCenterSDK-Specs-Private:
+  trunk:
     - AppCenter
+    - boost-for-react-native
 
 EXTERNAL SOURCES:
   appcenter-analytics:
@@ -387,11 +386,11 @@ EXTERNAL SOURCES:
     :path: "../node_modules/react-native/ReactCommon/yoga"
 
 SPEC CHECKSUMS:
-  AppCenter: abf4ddb72b71b6dcb6e27306ff7ce7184f2a388a
-  appcenter-analytics: 1aea9ada8922d2e2df3e069a28eda21157c9d30d
-  appcenter-core: c593b2e4ac28d6a21b6a217c4a5e6b3de7b0b00f
-  appcenter-crashes: d9ae1c9296974c1c433600fa2f320e0ba1f12bdf
-  AppCenterReactNativeShared: 0499e542cc149f89fed5dfe13fc5529d5242df0a
+  AppCenter: a4070ec3d4418b5539067a51f57155012e486ebd
+  appcenter-analytics: fbeef54afe6fa91d3803dfd31499817baa81fec0
+  appcenter-core: e192ea8b373bebd3e44998882b43311078bd7dda
+  appcenter-crashes: 266063788bcebd553e621344a54286395a8e2010
+  AppCenterReactNativeShared: d1d44ad6fe59594f806e54e70f06dadb2e78c4c4
   boost-for-react-native: 39c7adb57c4e60d6c5479dd8623128eb5b3f0f2c
   DoubleConversion: 5805e889d232975c086db112ece9ed034df7a0b2
   FBLazyVector: a93c5eef764b16789fa7875aac4e09119e806ad4
@@ -424,6 +423,6 @@ SPEC CHECKSUMS:
   RNScreens: 03bf608b92ac0acf323f47d8f5b63a8f829340c8
   Yoga: b5db822228963b87948afa7a5a531088607151dc
 
-PODFILE CHECKSUM: 5523256fea95f994fd212b1f9568454fbebe205a
+PODFILE CHECKSUM: f716ad4b9c697c1effa34ab0e1ac937458dac296
 
-COCOAPODS: 1.11.0
+COCOAPODS: 1.12.1

TestApp/ios/TestApp.xcodeproj/project.pbxproj

@@ -370,7 +370,7 @@
 					"$(inherited)",
 				);
 				INFOPLIST_FILE = TestAppTests/Info.plist;
-				IPHONEOS_DEPLOYMENT_TARGET = 9.0;
+				IPHONEOS_DEPLOYMENT_TARGET = 11.0;
 				LD_RUNPATH_SEARCH_PATHS = (
 					"$(inherited)",
 					"@executable_path/Frameworks",
@@ -394,7 +394,7 @@
 				COPY_PHASE_STRIP = NO;
 				DEVELOPMENT_TEAM = UBF8T346G9;
 				INFOPLIST_FILE = TestAppTests/Info.plist;
-				IPHONEOS_DEPLOYMENT_TARGET = 9.0;
+				IPHONEOS_DEPLOYMENT_TARGET = 11.0;
 				LD_RUNPATH_SEARCH_PATHS = (
 					"$(inherited)",
 					"@executable_path/Frameworks",
@@ -517,7 +517,7 @@
 				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
 				GCC_WARN_UNUSED_FUNCTION = YES;
 				GCC_WARN_UNUSED_VARIABLE = YES;
-				IPHONEOS_DEPLOYMENT_TARGET = 9.0;
+				IPHONEOS_DEPLOYMENT_TARGET = 11.0;
 				LIBRARY_SEARCH_PATHS = (
 					"\"$(TOOLCHAIN_DIR)/usr/lib/swift/$(PLATFORM_NAME)\"",
 					"\"$(TOOLCHAIN_DIR)/usr/lib/swift-5.0/$(PLATFORM_NAME)\"",
@@ -568,7 +568,7 @@
 				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
 				GCC_WARN_UNUSED_FUNCTION = YES;
 				GCC_WARN_UNUSED_VARIABLE = YES;
-				IPHONEOS_DEPLOYMENT_TARGET = 9.0;
+				IPHONEOS_DEPLOYMENT_TARGET = 11.0;
 				LIBRARY_SEARCH_PATHS = (
 					"\"$(TOOLCHAIN_DIR)/usr/lib/swift/$(PLATFORM_NAME)\"",
 					"\"$(TOOLCHAIN_DIR)/usr/lib/swift-5.0/$(PLATFORM_NAME)\"",
@@ -613,4 +613,4 @@
 /* End XCConfigurationList section */
 	};
 	rootObject = 83CBB9F71A601CBA00E9B192 /* Project object */;
-}
+}

TestApp/package.json

@@ -12,10 +12,10 @@
   },
   "dependencies": {
     "@react-native-community/async-storage": "1.6.2",
-    "appcenter": "file:appcenter-4.4.5.tgz",
-    "appcenter-analytics": "file:appcenter-analytics-4.4.5.tgz",
-    "appcenter-crashes": "file:appcenter-crashes-4.4.5.tgz",
-    "appcenter-link-scripts": "file:appcenter-link-scripts-4.4.5.tgz",
+    "appcenter": "file:appcenter-5.0.0.tgz",
+    "appcenter-analytics": "file:appcenter-analytics-5.0.0.tgz",
+    "appcenter-crashes": "file:appcenter-crashes-5.0.0.tgz",
+    "appcenter-link-scripts": "file:appcenter-link-scripts-5.0.0.tgz",
     "metro": "0.59.0",
     "react": "16.11.0",
     "react-native": "0.62.3",

appcenter-analytics/android/build.gradle

@@ -12,8 +12,8 @@ android {
     defaultConfig {
         minSdkVersion 21
         targetSdkVersion rootProject.properties.get('targetSdkVersion', 29)
-        versionCode 64
-        versionName '4.4.5'
+        versionCode 65
+        versionName '5.0.0'
         ndk {
             abiFilters 'armeabi-v7a', 'x86'
         }
@@ -24,8 +24,8 @@ dependencies {
     implementation fileTree(include: ['*.jar'], dir: 'libs')
     //noinspection GradleDynamicVersion
     implementation 'com.facebook.react:react-native:+'
-    api 'com.microsoft.appcenter:appcenter-analytics:4.4.5'
+    api 'com.microsoft.appcenter:appcenter-analytics:5.0.2'
 
     //api project(':AppCenterReactNativeShared')   // For testing with TestApp
-    api 'com.microsoft.appcenter.reactnative:appcenter-react-native:4.4.5'
+    api 'com.microsoft.appcenter.reactnative:appcenter-react-native:5.0.0'
 }

appcenter-analytics/appcenter-analytics.podspec

@@ -13,13 +13,13 @@ Pod::Spec.new do |s|
   s.author            = { 'Microsoft' => '[email protected]' }
   s.source            = { :git => "https://github.com/microsoft/appcenter-sdk-react-native.git" }
   s.source_files      = "ios/AppCenterReactNativeAnalytics/**/*.{h,m}"
-  s.platform          = :ios, '9.0'
+  s.platform          = :ios, '11.0'
   s.requires_arc      = true
 
   s.vendored_frameworks = 'AppCenterReactNativeShared/AppCenterReactNativeShared.framework'
 
-  s.dependency 'AppCenterReactNativeShared', '~> 4.0'
-  s.dependency 'AppCenter/Analytics', '~> 4.0'
+  s.dependency 'AppCenterReactNativeShared', '~> 5.0'
+  s.dependency 'AppCenter/Analytics', '~> 5.0'
   s.dependency 'React-Core'
   s.static_framework = true
 end

appcenter-analytics/package.json

@@ -1,6 +1,6 @@
 {
   "name": "appcenter-analytics",
-  "version": "4.4.5",
+  "version": "5.0.0",
   "description": "React Native plugin for AppCenter Analytics",
   "main": "Analytics.js",
   "types": "Analytics.d.ts",
@@ -20,7 +20,7 @@
   },
   "homepage": "https://github.com/Microsoft/appcenter-sdk-react-native/blob/master/appcenter-analytics/README.md",
   "dependencies": {
-    "appcenter": "4.4.5"
+    "appcenter": "5.0.0"
   },
   "rnpm": {
     "android": {

appcenter-analytics/scripts/postlink.js

@@ -34,8 +34,8 @@ if (rnpmlink.ios.checkIfAppDelegateExists()) {
             console.log(`Added code to initialize iOS Analytics SDK in ${file}`);
             return rnpmlink.ios.addPodDeps(
                 [
-                    { pod: 'AppCenter/Analytics', version: '4.4.3' },
-                    { pod: 'AppCenterReactNativeShared', version: '4.4.5' } // in case people don't link appcenter (core)
+                    { pod: 'AppCenter/Analytics', version: '5.0.3' },
+                    { pod: 'AppCenterReactNativeShared', version: '5.0.0' } // in case people don't link appcenter (core)
                 ],
                 { platform: 'ios', version: '9.0' }
             );