Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unix support #15

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Unix support #15

merged 1 commit into from
Apr 1, 2020

Conversation

CedricGuillemet
Copy link
Contributor

Unix support for task scheduler

@ryantrem
Copy link
Member

ryantrem commented Apr 1, 2020

@syntheticmagus - it would be nice if we could have something like a PlatformDefault directory alongside Android, iOS, etc., and use files from that directory when we don't have platform specific implementations. Is this possible/easy with cmakelists.txt?

@bghgary
Copy link
Contributor

bghgary commented Apr 1, 2020

@ryantrem CMakeLists.txt can certainly do this, but I don't know if it makes sense here. The current stop gap solution for threadpool_scheduler is a placeholder and I'm sure it should be used as the official fallback behavior.

@ryantrem
Copy link
Member

ryantrem commented Apr 1, 2020

@bghgary yea that's true, though I don't think the idea of having special platform specific implementations is abnormal. We can wait until we have a more "real" case of that though, it just seems like a hassle to have to do these kinds of updates when trying to use Arcana on a new platform.

@bghgary
Copy link
Contributor

bghgary commented Apr 1, 2020

I don't know. My opinion is that if we have platform specific code, we would rather know about what platforms are missing.

@bghgary
Copy link
Contributor

bghgary commented Apr 1, 2020

I've updated the title in #8 to reflect the new platform.

@bghgary bghgary merged commit b6748be into microsoft:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants