Rework ID-based parametrisation #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 10, 2024
a-lucic
reviewed
Sep 10, 2024
a-lucic
approved these changes
Sep 10, 2024
Co-authored-by: Ana Lucic <[email protected]>
|
I checked this PR against my fine tuning and was able to add variables w/out needing to directly modify the layers (all completed on the Small version of Aurora). Adding the ERA5 tsn var w/out any additional fine tuning results in After a few mins of fine tuning I get this for tsn For the existing 2t var I get this w/out finetuning And this after a few mins of fine tuning While I'm not super experienced yet with leveraging this model so far the behavior seems to be expected and its possible to add vars more easily than previously. |
|
Thanks, @scottcha! I'm going to interpret this as evidence that the refactoring works as intended and proceed to merging. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to extend the model to new variables.
Closes #24