Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement control channel in python host servicer #5427

Merged
merged 5 commits into from
Feb 10, 2025

Conversation

jackgerrits
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 10.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 78.31%. Comparing base (9ceb5c0) to head (ce3ae22).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ext/runtimes/grpc/_worker_runtime_host_servicer.py 10.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5427      +/-   ##
==========================================
+ Coverage   76.57%   78.31%   +1.73%     
==========================================
  Files         205      167      -38     
  Lines       10959     9906    -1053     
  Branches      139        0     -139     
==========================================
- Hits         8392     7758     -634     
+ Misses       2472     2148     -324     
+ Partials       95        0      -95     
Flag Coverage Δ
unittests 78.31% <10.00%> (+1.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jackgerrits jackgerrits force-pushed the impl_control_channel_host_servicer branch from adcffb2 to 76da508 Compare February 7, 2025 14:48
@ekzhu
Copy link
Collaborator

ekzhu commented Feb 10, 2025

@jackgerrits @lokitoth is this required to get x-lang to work for the immediate release?

@ekzhu ekzhu enabled auto-merge (squash) February 10, 2025 23:04
@ekzhu ekzhu merged commit 2612796 into main Feb 10, 2025
61 checks passed
@ekzhu ekzhu deleted the impl_control_channel_host_servicer branch February 10, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants