Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped gcr to 3.38.1 to fix a build break. #11738

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

PawelWMS
Copy link
Contributor

@PawelWMS PawelWMS commented Dec 31, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

We've recently hit a build break in gcr reported upstream. Bumping gcr to 3.38.1, where the fix was added.

Does this affect the toolchain?

No.

Associated issues
Test Methodology
  • Buddy build.
    NOTE: the package never built on 3.0, this PR is just to keep the changes in sync. Build failures will need to be addressed separately.

@PawelWMS PawelWMS requested review from a team as code owners December 31, 2024 19:28
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Dec 31, 2024
@PawelWMS PawelWMS requested a review from Copilot December 31, 2024 19:29

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (3)
  • SPECS-EXTENDED/gcr/gcr.signatures.json: Language not supported
  • SPECS-EXTENDED/gcr/gcr.spec: Language not supported
  • cgmanifest.json: Language not supported
@PawelWMS PawelWMS merged commit 8003850 into 3.0-dev Jan 2, 2025
13 checks passed
@PawelWMS PawelWMS deleted the pawelwi/fix_gcr_3.0 branch January 2, 2025 17:30
aninda-al pushed a commit to aninda-al/azurelinux-test that referenced this pull request Jan 2, 2025
aninda-al pushed a commit to aninda-al/azurelinux-test that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants