-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iptables: add back missing kernel modules for iptables #11982
Conversation
Co-authored-by: Christopher Co <[email protected]>
ip6table_mangle | ||
ip6table_nat | ||
ebt_ip | ||
nf_nat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add these modules as well:
ipt_ah
ipt_ECN
ipt_REJECT
ipt_rpfilter
ipt_SYNPROXY
Rationale: When i did a repro locally, I could see these modules also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were these enabled by default with the previous iptables package or only after the repro? If they weren't loaded before the repro, I don't think we'd want to add them to the conf file
Co-authored-by: Christopher Co <[email protected]>
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
Add back missing kernel modules for iptables introduced by change that enabled nftables
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology