Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: [#4684] Update nock dependency to latest version #4760

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

ceciliaavila
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR updates the nock package to version 13.5.5 fixing the failing test in botbuilder-dialogs-adaptive-testing.

Specific Changes

  • Updated nock from 11.9.1 to 13.5.5 in botbuilder, botbuilder-ai, botbuilder-dialogs-adaptive-testing, and botframework-connector.
  • Fixed failing test in botbuilder-dialogs-adaptive-testing. Nock no longer recognizes arrays as part of the request's body. We used JSON.stringify function for this case, as the tested functionality wasn't affected.

Testing

The following images show the unit tests passing after the upgrade.
image
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner September 30, 2024 13:52
@coveralls
Copy link

coveralls commented Sep 30, 2024

Pull Request Test Coverage Report for Build 11107578694

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.349%

Totals Coverage Status
Change from base Build 11057870464: 0.0%
Covered Lines: 20433
Relevant Lines: 22910

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 6a7f93c into main Sep 30, 2024
14 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/nock-dependency branch September 30, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants