Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: Update chai package #4844

Merged
merged 7 commits into from
Jan 24, 2025
Merged

bump: Update chai package #4844

merged 7 commits into from
Jan 24, 2025

Conversation

JhontSouth
Copy link
Collaborator

#minor

Description

This PR updates the chai package to the latest version and applies the necessary configuration to keep working.

Specific Changes

  • Updated chai to version ^5.1.2.
  • Added required packages for chai: @rollup/plugin-commonjs, @web/dev-server-rollup, jiti.
  • Added prebuild scripts to botbuilder and botframework-streaming to use tsup to compile ESM-only package.
  • Updated imports of chai in every class.

Testing

The following images show the unit tests working after the updates.
image
image

@JhontSouth JhontSouth requested a review from a team as a code owner January 14, 2025 15:42
@sw-joelmut sw-joelmut mentioned this pull request Jan 20, 2025
Closed
@JhontSouth
Copy link
Collaborator Author

@tracyboehrer, conflicts solved in this PR.

@tracyboehrer tracyboehrer merged commit 7534989 into main Jan 24, 2025
15 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/chai branch January 24, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JhontSouth @tracyboehrer