Fixed Swagger spec #6253
Open
Fixed Swagger spec #6253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Swagger spec, the operationId `Conversations_GetConversationMembers` was defined twice, and that caused an issue with the Swagger CLI's validation. One of the two instances should have been `Conversations_GetConversationMember` instead.
Adding `"x-nullable": true` to date fields and `"x-omitempty": true` to arrays to ensure that the resulting JSON doesn't include empty dates and empty arrays are not rendered as "null" when using go-swagger to generate a client
|
I made a second commit that also added:
When generating a client with go-swagger, these options are required to ensure that zero dates or empty arrays are not included in the resulting JSON. Not only including them would be a mistake, but they actually crash the Bot Framework Emulator app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Swagger spec, the operationId
Conversations_GetConversationMemberswas defined twice, and that caused an issue with the Swagger CLI's validation. One of the two instances should have beenConversations_GetConversationMemberinstead.