Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support buildTarget/run #145

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Support buildTarget/run #145

wants to merge 1 commit into from

Conversation

Arthurm1
Copy link
Contributor

Allows running of main methods using buildTarget/run BSP request

Supports scala-main-class RunParamsDataKind as there is no jvm specific data type.

Caveats...

  1. StdIn - not connected since run/readStdin not supported - need to upgrade BSP to 2.2
  2. StdOut - sent as log message since run/printStdout not supported - need to upgrade BSP to 2.2
  3. StdErr - sent as log message since run/printStderr not supported - need to upgrade BSP to 2.2
  4. Env vars are not passed - need to upgrade BSP to 2.2

@jdneo
Copy link
Member

jdneo commented May 30, 2024

Looks like a lot of features are missing before upgrading to 2.2

Is the code change big for upgrading the BSP to 2.2? If not, maybe we can upgrade first.

@Arthurm1
Copy link
Contributor Author

Is the code change big for upgrading the BSP to 2.2? If not, maybe we can upgrade first.

I don't think there's much difference. I'll submit a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arthurm1 @jdneo