Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support 'workspace/reload' #54

Merged
merged 1 commit into from
Jul 21, 2023
Merged

feat: support 'workspace/reload' #54

merged 1 commit into from
Jul 21, 2023

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Jul 21, 2023

@jdneo jdneo merged commit c4ce53b into develop Jul 21, 2023
@jdneo jdneo deleted the cs/reload branch July 21, 2023 08:07
Copy link
Member

@akaroml akaroml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just curious how the progress of a project reload/initialize is reported. And furthermore, how it can be canceled.

@jdneo
Copy link
Member Author

jdneo commented Jul 25, 2023

how it can be canceled.

I've no answer for this question. Looks into the spec, currently there is no cancel request/notification. Maybe I can ask them for clarification.

@jdneo
Copy link
Member Author

jdneo commented Jul 26, 2023

Maybe I can ask them for clarification.

The answer from BSP team: The cancellation mechanism in BSP is inherited from LSP. Which means client sends a $/cancelRequest and server responses with a ServerCancelled error code.

Filed an issue: #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants