This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Spelling #1048
Open
Spelling #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref
commented
Oct 2, 2022
| name: "MapChartElementkAttribute", | ||
| name: "MapChartElementAttribute", |
There was a problem hiding this comment.
It's possible this is important...
| @@ -51,7 +51,7 @@ import { EditorType } from "./stores/app_store"; | |||
| import { LocalizationConfig } from "../container/container"; | |||
|
|
|||
| export class ApplicationExtensionContext implements ExtensionContext { | |||
| constructor(public app: Application) {} | |||
| constructor(public app: Application) { } | |||
There was a problem hiding this comment.
I didn't do this. But I apparently opened this file in VSCode and some reformatting rule apparently insisted (it also rewrote my workflow yaml).
I'm willing to drop these changes, but do note that files should not trip up drive-by-contributors which means someone should really clean up the codebase so this doesn't happen when the next person drives by.
| localizaiton: LocalizationConfig, | ||
| localization: LocalizationConfig, |
There was a problem hiding this comment.
It's possible this is a public api. I hope it isn't...
| export * from "./messsage_box"; | ||
| export * from "./message_box"; |
| export function getAligntment(anchor: Element) { | ||
| export function getAlignment(anchor: Element) { |
| const gridineArcRotate = 90; | ||
| const gridlineArcRotate = 90; |
| * | ||
| *  |
| @@ -7,7 +7,7 @@ import { useEffect } from "react"; | |||
| import { ZoomInfo } from "../.."; | |||
| import { AxisDataBindingType } from "../../specification/types"; | |||
|
|
|||
| export interface VirtualScrollBarPropertes { | |||
| export interface VirtualScrollBarProperties { | |||
| @@ -10,7 +10,7 @@ import { snapToAttribute } from "../../prototypes/update_attribute"; | |||
| import { ConstraintPlugin, ConstraintSolver, Variable } from "../abstract"; | |||
|
|
|||
| // eslint-disable-next-line | |||
| export interface PolarCoordinatorPluginOptions {} | |||
| export interface PolarCoordinatorPluginOptions { } | |||
There was a problem hiding this comment.
See earlier note about random whitespace changes from formatters
| * * Solve sparse constrained linear least square problems using a lagrange method. | ||
| * * Solve sparse constrained linear least square problems using a Lagrange method. |
There was a problem hiding this comment.
Eigen below is capitalized. I don't see any reason not to treat Lagrange with similar respect.
zBritva
approved these changes
Oct 3, 2022
|
@bongshin: do I need to do something to push this along? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at jsoref@6a6d4eb#commitcomment-85635162
The action reports that the changes in this PR would make it happy: jsoref@21a7cf2
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.