Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Chart scaling #804

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Chart scaling #804

wants to merge 13 commits into from

Conversation

MrRamka
Copy link
Collaborator

@MrRamka MrRamka commented Oct 22, 2021

image

@MrRamka MrRamka marked this pull request as ready for review October 25, 2021 16:34
jrthompson33
jrthompson33 reviewed Nov 2, 2021
View reviewed changes
src/container/chart_component.tsx
@@ -48,6 +47,10 @@ export interface ChartComponentProps {
onGlyphMouseLeave?: GlyphEventHandler;
onGlyphContextMenuClick?: GlyphEventHandler;
renderEvents?: RenderEvents;

scale: number;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these fields (e.g., scale, viewWidth, viewHeight) required when serializing the chart component?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, no. They are only needed to show chart

jrthompson33
jrthompson33 reviewed Nov 2, 2021
View reviewed changes
Copy link

@jrthompson33 jrthompson33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the chart scaling need to be serialized when saving the chart?

@MrRamka
Copy link
Collaborator Author

MrRamka commented Nov 2, 2021

No, they are needed to view chart in visual

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrthompson33 jrthompson33 jrthompson33 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrRamka @jrthompson33