Skip to content

Remove unnecessary disk service and delete step #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aeweston-msft
Copy link
Contributor

Changes introduced by this PR

  • Remove the disk service from AzureStackHCIVirtualMachineService struct and the delete step from AzureStackHCIVirtualMachineService Delete flow
  • Remove the entire disk service which wraps moc-sdk-for-go, as it is unused after the change

I have been working on some task which required a review of the CAPH interactions with MOC and I realized that there is no need for the OS disk delete step.

This is because the OS disk is a resource whose lifecycle is completely managed within the VM service of MOC and is not represented as a VHD (It has a separate resource called VM image which is only referenced internally to MOC AFAIK). So this is essentially a no-op because this operation should always result in not found. I thought it would be good to remove this code and the corresponding disk service entirely to avoid having dead code and unnecessary calls to MOC. I was just wondering before making a PR what the testing expectations are for the CAPH repo.

Test plan

TBD, unsure of the expectations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant