Remove unnecessary disk service and delete step #296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced by this PR
I have been working on some task which required a review of the CAPH interactions with MOC and I realized that there is no need for the OS disk delete step.
This is because the OS disk is a resource whose lifecycle is completely managed within the VM service of MOC and is not represented as a VHD (It has a separate resource called VM image which is only referenced internally to MOC AFAIK). So this is essentially a no-op because this operation should always result in not found. I thought it would be good to remove this code and the corresponding disk service entirely to avoid having dead code and unnecessary calls to MOC. I was just wondering before making a PR what the testing expectations are for the CAPH repo.
Test plan
TBD, unsure of the expectations