Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding TypeScript Support and Removing github/codeql-go References #50

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Adding TypeScript Support and Removing github/codeql-go References #50

merged 3 commits into from
Mar 13, 2023

Conversation

grizzls
Copy link
Contributor

@grizzls grizzls commented Jan 19, 2023 •
edited
Loading

When scanning javascript project that use typeScript, we are getting the following error:

[build-stderr] Could not start Node.js. It is required for TypeScript extraction.                                                    
[build-stderr] Please install Node.js and ensure 'node' is on the PATH.

@grizzls
Copy link
Contributor Author

grizzls commented Jan 19, 2023

@microsoft-github-policy-service agree

@grizzls grizzls mentioned this pull request Jan 19, 2023
Closed
@sargemonkey
Copy link

sargemonkey commented Jan 23, 2023 •
edited
Loading

@scovetta , this looks good to merge too pending some changes.. Thanks @grizzls

sargemonkey
sargemonkey reviewed Jan 23, 2023
View reviewed changes
Copy link

@sargemonkey sargemonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove line 67 too, and any related references to the folder

@grizzls
Copy link
Contributor Author

grizzls commented Jan 23, 2023

We can remove line 67 too, and any related references to the folder

Done!

intrigus-lgtm
intrigus-lgtm reviewed Jan 25, 2023
View reviewed changes
Dockerfile
gettext && \
apt-get clean && \
rm -f /usr/bin/python /usr/bin/pip && \
ln -s /usr/bin/python3.8 /usr/bin/python && \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the pip3 symlinking, but can this line not be replaced by also installing the python-is-python3 package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's beyond the scope of this PR. All I want is TypeScript support and to fix the broken build. I'll leave that up to the maintainers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll incorporate this comment into my next PR, thanks @intrigus-lgtm!

@grizzls
Copy link
Contributor Author

grizzls commented Jan 26, 2023

@surajjacob @scovetta Anything else we need to do to get this merged?

@grizzls
Copy link
Contributor Author

grizzls commented Mar 13, 2023

@jacobmsft & @scovetta any updates on getting this merged?

@jacobmsft
Copy link
Member

@jacobmsft & @scovetta any updates on getting this merged?

you got it, sorry for the delay.

@jacobmsft jacobmsft merged commit f632b80 into microsoft:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sargemonkey sargemonkey sargemonkey left review comments

@jacobmsft jacobmsft jacobmsft left review comments

@intrigus-lgtm intrigus-lgtm intrigus-lgtm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grizzls @sargemonkey @jacobmsft @intrigus-lgtm