Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Backward compatibility: Test-JSONChecksum #36

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

TinaMor
Copy link
Contributor

@TinaMor TinaMor commented Aug 29, 2024

PR description

The command syntax for Test-JSON differs between PowerShell versions 7.2 (used in #35) and 7.4 (used to develop this module). For backward compatibility, we use the syntax common to both versions: Test-Json -Json -Schema instead of Test-Json -Path -SchemaFile .

Github issue/ discussion

Issue #35

Relevant links

Checklist

As part of our commitment to engineering excellence, before submitting this PR, please make sure:

  • You've tested this code in both Desktop & Server environments and AMD & ARM64 enviroments (functional testing).
  • You've added unit tests for new code.
  • You've added/updated documentation in the cmdlet docs, command-reference.md and the modules help files.
  • You've reviewed the PR/code best practices defined in the CONTRIBUTING.md.

In addition, after this PR has been reviewed, please agree to:

  • If changes have been made to your PR in the process of addressing comments, please make sure to test again the final version in both AMD and ARM64 environments.
  • Validate your changes have not introduced any regressions.

@TinaMor TinaMor marked this pull request as draft August 29, 2024 20:28
@TinaMor TinaMor marked this pull request as ready for review August 29, 2024 20:39
@TinaMor TinaMor force-pushed the tinamor/fix-test-jsonchecksum branch 4 times, most recently from c55a494 to b282f19 Compare August 29, 2024 21:32
    - To ensure backward compatibility, we use the older Test-JSON -JSON syntax instead of the Test-JSON -Path command, which was introduced in later versions of PowerShell 7.
@TinaMor TinaMor force-pushed the tinamor/fix-test-jsonchecksum branch from b282f19 to e147c86 Compare August 29, 2024 21:34
Copy link

@iankingori iankingori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TinaMor TinaMor merged commit 04030e6 into microsoft:main Aug 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants