Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add synapse support #128

Merged
merged 3 commits into from
Aug 30, 2024
Merged

feat: add synapse support #128

merged 3 commits into from
Aug 30, 2024

Conversation

jayachithra
Copy link
Collaborator

@jayachithra jayachithra commented Aug 26, 2024 •
edited
Loading

@jayachithra jayachithra linked an issue Aug 26, 2024 that may be closed by this pull request
[Question] Support for Synapse Pipelines #82
Closed
@jayachithra jayachithra added the enhancement New feature or request label Aug 26, 2024
@jayachithra jayachithra self-assigned this Aug 26, 2024
LeonardHd
LeonardHd reviewed Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@LeonardHd LeonardHd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is amazingly compact and well done for adding support of another product.
Just leaving a few thoughts/remarks - the final decision would be with @arjendev.

Maybe we should consider adding all TestFrameworkTypes to our api tests that should guarantee we do not break the APIs (see here

data-factory-testing-framework/tests/functional/api/test_package_api.py

Line 28 in 9c3b637

def test_package_classes() -> None:
)

examples/data_factory/copy_blobs/test_data_factory_copy_blobs_unit.py Outdated Show resolved Hide resolved
src/data_factory_testing_framework/_test_framework.py Show resolved Hide resolved
tests/functional/switch_activity_pipeline/test_switch_activity_pipeline.py Outdated Show resolved Hide resolved
arjendev
arjendev requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@arjendev arjendev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @jayachithra! This is going to open up the framework for a ton of additional users!

README.md Outdated Show resolved Hide resolved
examples/data_factory/copy_blobs/test_data_factory_copy_blobs_unit.py Outdated Show resolved Hide resolved
src/data_factory_testing_framework/_test_framework.py Show resolved Hide resolved
tests/functional/execute_child_pipeline/test_execute_child_pipeline_activity.py Outdated Show resolved Hide resolved
LeonardHd
LeonardHd previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@LeonardHd LeonardHd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for answering and clarifying - LGTM and will approve.

arjendev
arjendev reviewed Aug 27, 2024
View reviewed changes
README.md Show resolved Hide resolved
@jayachithra jayachithra force-pushed the feat/synapse-support branch 7 times, most recently from 1867c5c to d36ca30 Compare August 30, 2024 13:18
arjendev
arjendev previously approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@arjendev arjendev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a yet huuuge milestone for the framework, awesome work @jayachithra!

Approving! As discussed, please make sure the switch default-case is still covered with tests.
I trust you and Leonard to ensure this is covered, thanks!

@jayachithra jayachithra force-pushed the feat/synapse-support branch 3 times, most recently from 4c6c4e4 to 0f18ef9 Compare August 30, 2024 14:45
@LeonardHd
Copy link
Collaborator

Ok, checked default_activities in SwitchActivity are covered (I assume that was needed) - so LGTM!

@jayachithra jayachithra merged commit 10ab4c6 into main Aug 30, 2024
29 checks passed
@LeonardHd LeonardHd deleted the feat/synapse-support branch September 1, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonardHd LeonardHd LeonardHd approved these changes

@arjendev arjendev arjendev left review comments

Assignees

@jayachithra jayachithra

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question] Support for Synapse Pipelines
3 participants
@jayachithra @LeonardHd @arjendev