Skip to content

Commit

Permalink
Update SSH package version, support IPv6 localhost
Browse files Browse the repository at this point in the history
  • Loading branch information
jasongin committed Jul 28, 2023
1 parent 4f43a81 commit ef5b113
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion cs/build/build.props
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
<ReportGeneratorVersion>4.8.13</ReportGeneratorVersion>
<SystemTextEncodingsWebPackageVersion>4.7.2</SystemTextEncodingsWebPackageVersion>
<VisualStudioValidationVersion>15.5.31</VisualStudioValidationVersion>
<DevTunnelsSshPackageVersion>3.11.13</DevTunnelsSshPackageVersion>
<DevTunnelsSshPackageVersion>3.11.16</DevTunnelsSshPackageVersion>
<XunitRunnerVisualStudioVersion>2.4.0</XunitRunnerVisualStudioVersion>
<XunitVersion>2.4.0</XunitVersion>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion cs/src/Connections/TunnelHost.cs
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ internal async Task ForwardPortAsync(
forwarder = await pfs.ForwardFromRemotePortAsync(
IPAddress.Loopback,
portNumber,
IPAddress.Loopback.ToString(),
'localhost',

Check failure on line 130 in cs/src/Connections/TunnelHost.cs

View check run for this annotation

Azure Pipelines / Dev-Tunnels SDK C# PR Build

cs/src/Connections/TunnelHost.cs#L130

cs/src/Connections/TunnelHost.cs(130,17): Error CS1012: Too many characters in character literal

Check failure on line 130 in cs/src/Connections/TunnelHost.cs

View check run for this annotation

Azure Pipelines / Dev-Tunnels SDK C# PR Build

cs/src/Connections/TunnelHost.cs#L130

cs/src/Connections/TunnelHost.cs(130,17): Error CS1012: Too many characters in character literal
portNumber,
cancellation);
}
Expand Down
16 changes: 8 additions & 8 deletions ts/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
"build-pack-publish": "npm run build && npm run pack && npm run publish"
},
"dependencies": {
"@microsoft/dev-tunnels-ssh": "^3.11.13",
"@microsoft/dev-tunnels-ssh-tcp": "^3.11.13",
"@microsoft/dev-tunnels-ssh": "^3.11.16",
"@microsoft/dev-tunnels-ssh-tcp": "^3.11.16",
"await-semaphore": "^0.1.3",
"axios": "^0.21.1",
"buffer": "^5.2.1",
Expand Down
4 changes: 2 additions & 2 deletions ts/src/connections/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
"vscode-jsonrpc": "^4.0.0",
"@microsoft/dev-tunnels-contracts": "^1.0.0",
"@microsoft/dev-tunnels-management": "^1.0.0",
"@microsoft/dev-tunnels-ssh": "^3.11.13",
"@microsoft/dev-tunnels-ssh-tcp": "^3.11.13",
"@microsoft/dev-tunnels-ssh": "^3.11.16",
"@microsoft/dev-tunnels-ssh-tcp": "^3.11.16",
"uuid": "^3.3.3",
"await-semaphore": "^0.1.3",
"websocket": "^1.0.28",
Expand Down
2 changes: 1 addition & 1 deletion ts/src/connections/tunnelHostBase.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export class TunnelHostBase
const forwarder = await pfs.forwardFromRemotePort(
this.loopbackIp,
portNumber,
this.loopbackIp,
'localhost',
portNumber,
);
if (!forwarder) {
Expand Down

0 comments on commit ef5b113

Please sign in to comment.