rs: support ipv6 port-forwarded services #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipv6-only services are getting more common, especially with a Node 18 change that causes it to listen on ipv6 by default on most enabled networks. In advance of releasing local forwarding for vscode, I think we should support this. This PR supports local ipv6 forwarding by reaching out to both the ipv6 and ipv4 interfaces by default, and using whichever one (if any) accepts the TCP connection first.
taiyosogawa
approved these changes
Aug 21, 2023
This was referenced Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
ipv6-only services are getting more common, especially with a Node 18
change that causes it to listen on ipv6 by default on most enabled
networks. In advance of releasing local forwarding for vscode, I think
we should support this.
This PR supports local ipv6 forwarding by reaching out to both the ipv6
and ipv4 interfaces by default, and using whichever one (if any)
accepts the TCP connection first.
Other Tasks: