Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forceCreate and forceUpdate query params #335

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Add forceCreate and forceUpdate query params #335

merged 5 commits into from
Oct 18, 2023

Conversation

jfullerton44
Copy link
Collaborator

@jfullerton44 jfullerton44 commented Oct 17, 2023 •
edited
Loading

Fixes #

Changes proposed:

  • Adds query params to force a tunnel update or tunnel create that will be added to the service in a different PR
  • Fixes issue in typescript where last retry message would get a clusterId missing error

Other Tasks:

  • If you updated the Go SDK did you update the PackageVersion in tunnels.go

@jfullerton44 jfullerton44 merged commit 9d1f67c into main Oct 18, 2023
11 checks passed
@jfullerton44 jfullerton44 deleted the dev/jfullerton/forceCreate branch October 18, 2023 03:51
jfullerton44 added a commit that referenced this pull request Oct 26, 2023
@jfullerton44
Revert "Add forceCreate and forceUpdate query params (#335)"
7be15d7 
This reverts commit 9d1f67c.
jfullerton44 added a commit that referenced this pull request Oct 27, 2023
@jfullerton44
Add CreateOrUpdate tunnels and ports and forced updates and creates w…
0e65ace 
…ith headers (#336)

* Revert "Revert "add create or update methods""

This reverts commit df18548.

* fix ts build issues

* fix cs builds

* go version

* Revert "Add forceCreate and forceUpdate query params (#335)"

This reverts commit 9d1f67c.

* use header for c# sdk

* update create and update

* add port headers

* add headers to ts

* java and go updates

* add precondition exception

* use const

* pr fixes

* update port setting

* fix build issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlyaBiryukov IlyaBiryukov IlyaBiryukov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfullerton44 @IlyaBiryukov