Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal usage of ValidateTokenExpiration. #393

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

jramsay
Copy link
Member

@jramsay jramsay commented Jan 31, 2024

Changes proposed:

  • Remove internal usage of ValidateTokenExpiration. It is based on user's system time and is causing reliability issues where "The access token is expired" is reported due to client system time issues.
  • Add a note to all external API validation calls that this uses client's system time for validation

Other Tasks:

  • If you updated the Go SDK did you update the PackageVersion in tunnels.go
  • If you updated the TS SDK did you update the dependencies in package.json for connections and management to require a dependency that is > the current published version(Found using npm view @microsoft/dev-tunnels-contracts). This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See example PR

@jramsay jramsay merged commit 56e1761 into main Jan 31, 2024
11 checks passed
@jramsay jramsay deleted the dev/jasonra/remove-token-validation branch January 31, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants