Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #395

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Update README.md #395

merged 1 commit into from
Feb 6, 2024

Conversation

taiyosogawa
Copy link
Contributor

Fixes #

Changes proposed:

Other Tasks:

  • If you updated the Go SDK did you update the PackageVersion in tunnels.go
  • If you updated the TS SDK did you update the dependencies in package.json for connections and management to require a dependency that is > the current published version(Found using npm view @microsoft/dev-tunnels-contracts). This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See example PR

jfullerton44
jfullerton44 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@jfullerton44 jfullerton44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@taiyosogawa taiyosogawa merged commit 8f920d7 into main Feb 6, 2024
11 checks passed
@taiyosogawa taiyosogawa deleted the taiyosogawa-patch-1 branch February 6, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfullerton44 jfullerton44 jfullerton44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiyosogawa @jfullerton44