Run all scripts as job with timeout. #3971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shankarseal
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
shankarseal
force-pushed
the
cleanup_hang_detect
branch
4 times, most recently
from
ea70c93
to
bf11d39
Compare
shankarseal
force-pushed
the
cleanup_hang_detect
branch
from
bf11d39
to
80834ad
Compare
shankarseal
force-pushed
the
cleanup_hang_detect
branch
from
f41ec54
to
d626aa3
Compare
Alan-Jowett
approved these changes
Nov 5, 2024
saxena-anurag
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Have the setup, execute and cleanup scripts run as a job with a timeout. Upon timeout a VM checkpoint is taken and an error is returned from the script.
This addresses #3949 by making it easier to debug the next time a hang occurs.
Testing
CICD.
Documentation
N/A.
Installation
N/A.