Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundation: Update Accordion template element naming #6796

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

bheston
Copy link
Collaborator

@bheston bheston commented Aug 7, 2023

Pull Request

📖 Description

As part of the next major release of fast-foundation, we wanted to do a complete review of the component templates and align the structure and naming as much as possible.

This PR is split from #6286 and applies to Accordion and Accordion Item.

Before on the left, update on the right. "C" = class, "P" = part, "R" = role, "S" = slot. 💔 = potentially style-breaking.

Accordion

  • Remove unused <template> wrapper

Accordion

Accordion item

  • 💔 Rename “icon” to “expand-collapse-icon”
  • 💔 Rename "region" class and part to "panel"

Accordion item

👩‍💻 Reviewer Notes

Review the Storybook site, or the illustrations of the components before and after, compared to the changes in code.

📑 Test Plan

Tested via comparison against proposal and in Storybook.

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

@bheston bheston self-assigned this Aug 7, 2023
@bheston bheston force-pushed the users/bheston/foundation-accordion-update branch from d500f86 to e4809be Compare August 8, 2023 01:49
@bheston bheston force-pushed the users/bheston/foundation-accordion-update branch 3 times, most recently from f986de1 to 2173bae Compare September 24, 2023 19:35
@bheston bheston force-pushed the users/bheston/foundation-accordion-update branch from 7aeadd1 to b0100e9 Compare March 7, 2024 21:28
@bheston bheston requested review from scomea and radium-v as code owners March 7, 2024 21:28
@bheston bheston merged commit 9d7b36d into master Mar 7, 2024
9 of 10 checks passed
@bheston bheston deleted the users/bheston/foundation-accordion-update branch March 7, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants