Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundation: Update Number field, Search, Switch, Text area, and Text field #6798

Merged
merged 5 commits into from
Mar 9, 2024

Conversation

bheston
Copy link
Collaborator

@bheston bheston commented Aug 8, 2023

Pull Request

📖 Description

As part of the next major release of fast-foundation, we wanted to do a complete review of the component templates and align the structure and naming as much as possible.

This PR is split from #6286 and standardizes Number field, Search, Switch, Text area, and Text field.

Before on the left, update on the right. "C" = class, "P" = part, "R" = role, "S" = slot. 💔 = potentially style-breaking.

Number field

  • 💔 Rename “control” to “field”
  • 💔 Rename “root” to “control”
  • 💔 Rename “controls” to “step-buttons”
  • 💔 Rename “step-up-glyph” to “step-up-icon”
  • 💔 Rename “step-down-glyph” to “step-down-icon”

Number field

Search

  • 💔 Rename “control” to “field”
  • 💔 Rename “root” to “control”
  • 💔 Remove “input-wrapper”
  • 💔 Rename “clear-glyph” to “clear-icon”

Search

Switch

  • 💔 Rename “switch” to “control”
  • 💔 Rename "switch" slot to "thumb"
  • Add default "thumb" element with class and part

Switch

Text area

  • 💔 Rename “control” to “field”
  • Add wrapper element “control”
  • Add "start" and "end" slots

Text area

Text field

  • 💔 Rename “control” to “field”
  • 💔 Rename “root” to “control”

Text field

👩‍💻 Reviewer Notes

Review the Storybook site, or the illustrations of the components before and after, compared to the changes in code.

📑 Test Plan

Tested via comparison against proposal and in Storybook.

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

@bheston bheston force-pushed the users/bheston/foundation-input-update branch from 5ac6859 to c06ab10 Compare August 8, 2023 01:48
@bheston bheston self-assigned this Aug 8, 2023
@scomea
Copy link
Collaborator

scomea commented Aug 10, 2023

Text/Number/Search field inputs don't track width of parent component in samples -

image

Copy link
Collaborator

@scomea scomea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from the input field sizing issue.

Copy link
Collaborator

@KingOfTac KingOfTac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from the changes @scomea requested

@bheston bheston force-pushed the users/bheston/foundation-input-update branch from c06ab10 to e681f29 Compare September 24, 2023 21:07
@bheston bheston requested a review from scomea September 24, 2023 22:29
@bheston bheston force-pushed the users/bheston/foundation-input-update branch from e681f29 to 4836239 Compare March 9, 2024 20:18
@bheston bheston requested a review from radium-v as a code owner March 9, 2024 20:18
@bheston
Copy link
Collaborator Author

bheston commented Mar 9, 2024

I tested the width issue in Storybook by manually adding width: 500px to each host element and found no issues. Hopefully that was the problem, either way there shouldn't be an issue with the underlying components, potentially only the local Storybook sample styling.

@bheston bheston merged commit 0d592e2 into master Mar 9, 2024
9 of 10 checks passed
@bheston bheston deleted the users/bheston/foundation-input-update branch March 9, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants