Fix bug in toolbar click handler when a slotted element has child elements #6830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mollykreis
requested review from
EisenbergEffect,
chrisdholt and
nicholasrice
as code owners
mollykreis
changed the title
|
Could someone take a look at this PR or provide an estimate of when it might get reviewed? Thanks |
|
Any update on when this PR might get some attention? |
I'll take a look in the next day or two, thanks @mollykreis. |
chrisdholt
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
LGTM - thanks for the tests @mollykreis. I'll update the change file.
change/@microsoft-fast-foundation-2ada25c3-3fb4-48ba-893d-e64d11f7f095.json
Outdated
Show resolved
Hide resolved
scomea
approved these changes
Sep 26, 2023
mollykreis
added a commit
to mollykreis/fast
that referenced
this pull request
Oct 12, 2023
…ments (microsoft#6830) * Fix bug with nested elements in toolbar click handler * Change files * lint * update change description * slight test improvement * Update change/@microsoft-fast-foundation-2ada25c3-3fb4-48ba-893d-e64d11f7f095.json --------- Co-authored-by: Chris Holt <[email protected]>
chrisdholt
added a commit
that referenced
this pull request
Oct 25, 2023
* Fix bug in toolbar click handler when a slotted element has child elements (#6830) * Fix bug with nested elements in toolbar click handler * Change files * lint * update change description * slight test improvement * Update change/@microsoft-fast-foundation-2ada25c3-3fb4-48ba-893d-e64d11f7f095.json --------- Co-authored-by: Chris Holt <[email protected]> * Fix toolbar focus bug (#6836) * Fix focus issue when clicking on an element in the toolbar * remove describe.only * Change files * Update api-report.md * Update change/@microsoft-fast-foundation-903a969b-3de3-4090-974a-3423344c571c.json --------- Co-authored-by: Chris Holt <[email protected]> * update change files * revert unintended change --------- Co-authored-by: Chris Holt <[email protected]>
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
…ments (#6830) * Fix bug with nested elements in toolbar click handler * Change files * lint * update change description * slight test improvement * Update change/@microsoft-fast-foundation-2ada25c3-3fb4-48ba-893d-e64d11f7f095.json --------- Co-authored-by: Chris Holt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Resolves #6819
When an element in the toolbar is clicked, the toolbar's
activeIndexshould update to be the index of that clicked item. However, there is a bug where this does not happen if a child element within the slotted element is clicked. This PR is intended to resolve that bug.🎫 Issues
#6819
👩💻 Reviewer Notes
I've updated the
clickHandlerfor the toolbar to searchfocusableElementsfor an entry that contains the clicked element rather than an entry that is the clicked element. No other logic has changed.📑 Test Plan
I've added two additional tests for the toolbar:
activeIndexupdates when an element slotted into the toolbar is clicked (passed with & without this change)activeIndexupdates when a nested element within an element slotted into the toolbar is clicked (failed without this change & passes with this change)✅ Checklist
General
$ yarn changeComponent-specific
⏭ Next Steps
N/A