Fix toolbar focus bug #6836
Merged
Fix toolbar focus bug #6836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mollykreis
requested review from
EisenbergEffect,
chrisdholt and
nicholasrice
as code owners
scomea
approved these changes
Sep 22, 2023
|
Could I get a second review on this PR? @EisenbergEffect @chrisdholt @nicholasrice |
Yep, I've got it pulled down to smoke and validate. Thanks |
|
@chrisdholt, were you able to perform the validation you wanted on this branch? |
chrisdholt
reviewed
Oct 11, 2023
change/@microsoft-fast-foundation-903a969b-3de3-4090-974a-3423344c571c.json
Outdated
Show resolved
Hide resolved
chrisdholt
approved these changes
Oct 11, 2023
mollykreis
added a commit
to mollykreis/fast
that referenced
this pull request
Oct 12, 2023
* Fix focus issue when clicking on an element in the toolbar * remove describe.only * Change files * Update api-report.md * Update change/@microsoft-fast-foundation-903a969b-3de3-4090-974a-3423344c571c.json --------- Co-authored-by: Chris Holt <[email protected]>
chrisdholt
added a commit
that referenced
this pull request
Oct 25, 2023
* Fix bug in toolbar click handler when a slotted element has child elements (#6830) * Fix bug with nested elements in toolbar click handler * Change files * lint * update change description * slight test improvement * Update change/@microsoft-fast-foundation-2ada25c3-3fb4-48ba-893d-e64d11f7f095.json --------- Co-authored-by: Chris Holt <[email protected]> * Fix toolbar focus bug (#6836) * Fix focus issue when clicking on an element in the toolbar * remove describe.only * Change files * Update api-report.md * Update change/@microsoft-fast-foundation-903a969b-3de3-4090-974a-3423344c571c.json --------- Co-authored-by: Chris Holt <[email protected]> * update change files * revert unintended change --------- Co-authored-by: Chris Holt <[email protected]>
1 task
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
* Fix focus issue when clicking on an element in the toolbar * remove describe.only * Change files * Update api-report.md * Update change/@microsoft-fast-foundation-903a969b-3de3-4090-974a-3423344c571c.json --------- Co-authored-by: Chris Holt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Resolves #6835
There is a bug where when clicking on an element in the toolbar focuses the
activeIndexelement before focusing the clicked element. This can lead to visual oddities. This PR is intended to resolve that bug.🎫 Issues
#6835
👩💻 Reviewer Notes
I changed the toolbar to use the
mousedownevent rather than theclickevent to update the toolbar'sactiveIndexbecause themousedownevent is fired beforefocusin, thus resolving the timing issue wherefocusinfocused the previously focused element prior toclickfocusing the newly focused element.📑 Test Plan
I wasn't able to write a test that failed prior to my change but passes with it because the issue was a temporary state that was passed through during a
clickoperations. However, I wrote two new tests that exercise the modified code path.I also manually tested my change in Chrome, Edge, and Firefox.
✅ Checklist
General
$ yarn changeComponent-specific
⏭ Next Steps
N/A